Re: [edk2-devel] [PATCH V2 00/32] Introduce AMD Vangogh platform reference code

2024-01-26 Thread Chang, Abner via groups.io
Hi Duke, Besides the AMD copyright is put in an improper place. I also found that there are several #include guards that don't follow edk2 C coding standard. There are several trailing underscores (like four underscores) attached to the macro. Please just put one trailing underscore as "INCLUDE_

[edk2-devel] [PATCH V2 00/32] Introduce AMD Vangogh platform reference code

2024-01-25 Thread Zhai, MingXin (Duke) via groups.io
From: Duke Zhai In V2: Improve coding style. 1.Remove the leading underscore and use double underscore at trailing in C header files. 2.Remove old tianocore licenses and redundant license description. 3.Improve coding style. For example: remove space between @param. In V1: This AMD refe