Re: [edk2-devel] [PATCH V2 0/4] Enable Dynamic ACPI for LS1046AFRWY

2021-08-13 Thread Vikas Singh via groups.io
Sunny, Apologies for late response. (Not keeping well these days) Ok, PSB my remarks. #1. True, if an entity is independently getting build must be prefixed with Pkg. In my previous discussion with Leif (https://edk2.groups.io/g/devel/message/70090) Leif requested a reason of this kind of setup

Re: [edk2-devel] [PATCH V2 0/4] Enable Dynamic ACPI for LS1046AFRWY

2021-08-04 Thread Sunny Wang
Hi Vikas, Sorry for the delay and thanks for clarifying. Added my further rcomments below: 1. For your previous discussion with Leif, do you mean this one https://edk2.groups.io/g/devel/message/70090? If my understanding of your previous discussion is correct, the reason why you needed to

Re: [edk2-devel] [PATCH V2 0/4] Enable Dynamic ACPI for LS1046AFRWY

2021-07-26 Thread Vikas Singh via groups.io
Sunny,thanks for your review and PSB my remarks. From: Sunny Wang Sent: Monday, July 12, 2021 4:03 PM To: Vikas Singh ; devel@edk2.groups.io ; Meenakshi Aggarwal (meenakshi.aggar...@nxp.com) ; l...@nuviainc.com Cc: Sami Mujawar ; l...@nuviainc.com ; Samer

Re: [edk2-devel] [PATCH V2 0/4] Enable Dynamic ACPI for LS1046AFRWY

2021-07-12 Thread Sunny Wang
Hi Vikas, Thanks for working on this. As our offline discussion with NXP, our goal is to make the Tiano edk2-platform and NXP LSDK opensource https://source.codeaurora.org/external/qoriq/qoriq-components/edk2-platforms in sync. Now the main problem is that some folders' names and locations hav

[edk2-devel] [PATCH V2 0/4] Enable Dynamic ACPI for LS1046AFRWY

2021-06-18 Thread Vikas Singh via groups.io
This patch series basically aims to extend the Dynamic ACPI framework towards NXP's LS1046AFRWY platform. In continuation to https://edk2.groups.io/g/devel/message/71709 The change set in the series is in below order - (1)Introducing a new platform specific macro "PLAT_SOC_NAME" This macro will