Re: [edk2-devel] [PATCH V2 0/4] CryptoPkg: add more X509 functions.

2022-10-11 Thread Sean
; Jiang, Guomin Subject: RE: [edk2-devel] [PATCH V2 0/4] CryptoPkg: add more X509 functions. HI Sean You are right that the purpose is NOT to expose *all* APIs. Our purpose is still to export *necessary* APIs only. This X.509 is for SPDM support. (https://www.dmtf.org/dsp/DSP0274). The BIOS may

Re: [edk2-devel] [PATCH V2 0/4] CryptoPkg: add more X509 functions.

2022-10-10 Thread Yao, Jiewen
Jiewen > -Original Message- > From: Sean Brogan > Sent: Tuesday, October 11, 2022 5:01 AM > To: devel@edk2.groups.io; Zhang, Qi1 > Cc: Yao, Jiewen ; Wang, Jian J > ; Lu, Xiaoyu1 ; Jiang, > Guomin > Subject: Re: [edk2-devel] [PATCH V2 0/4] CryptoPkg: add more X509 &

Re: [edk2-devel] [PATCH V2 0/4] CryptoPkg: add more X509 functions.

2022-10-10 Thread Sean
Can you provide some context as to why we need to make all these x509 functions external? BaseCryptLib was intended to simplify crypto usage and not be a full featured crypto library interface. At some point we might as well just open up the openssl export table and wrap that in a dynamicall

[edk2-devel] [PATCH V2 0/4] CryptoPkg: add more X509 functions.

2022-10-10 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4082 This patch serial is to add more CryptoX509 functions. Tested by: 1. https://github.com/tianocore/edk2-staging/tree/DeviceSecurity. 2. Unit test: CryptoPkg/Test/UnitTest/Library/BaseCryptLib/X509Tests.c Review PR: https://github.com/tianoc