Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-19 Thread Pethaiyan, Madhan
Hi All, I had corrected the description, added the UEFI spec version and section details . Please check and approve it Thanks, P. Madhan -Original Message- From: Pethaiyan, Madhan Sent: Monday, January 8, 2024 12:13 PM To: devel@edk2.groups.io Cc: Pethaiyan, Madhan ; Gao, Liming ; K

Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-18 Thread Michael D Kinney
Hi Madhan, There are 2 additional files that need function header updates: * SignedCapsulePkg\Universal\SystemFirmwareUpdate\SystemFirmwareCommonDxe.c * SignedCapsulePkg\Universal\SystemFirmwareUpdate\SystemFirmwareDxe.h In addition, there are function headers in the edk2-platforms repo that al

Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-18 Thread Michael D Kinney
Hi Madhan, The patch you provided does fix the logic in the .c file, but the update is incomplete. * FmpDevicePkg/FmpDxe/FmpDxe.c - Update GetTheImageInfo() function header to match the UEFI 2.10 specification that includes all the conditions to return EFI_INVALID_PARAMETER. * FmpDevicePkg/

Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-18 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Pethaiyan, Madhan > Sent: Thursday, January 18, 2024 12:57 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Xu, Wei6 ; Tan, Ming > ; S, Ashraf Ali > Subject: RE: [PATCH V2] FmpDevicePkg: GetImageInfo Add

[edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition

2024-01-09 Thread Pethaiyan Madhan
From: "Pethaiyan, Madhan" UEFI Spec 2.10 , 23.1 Firmware Management Protocol , Added missing condition check under GetImageInfo function, if the PackageVersionName is NULL return EFI_INVALID_PARAMETER Signed-off-by: Pethaiyan Madhan Cc: Liming Gao Cc: Michael D Kinney Cc: Wei6 Xu --- FmpDe