Re: [edk2-devel] [PATCH V2] BaseTools:Add [packages] section in dsc file

2019-11-19 Thread Liming Gao
The test case is ok to me. Acked-by: Liming Gao Thanks Liming >-Original Message- >From: Fan, ZhijuX >Sent: Wednesday, November 20, 2019 10:46 AM >To: Gao, Liming ; devel@edk2.groups.io >Cc: Feng, Bob C >Subject: RE: [PATCH V2] BaseTools:Add [packages] section in dsc file > >Hi: > >reg

Re: [edk2-devel] [PATCH V2] BaseTools:Add [packages] section in dsc file

2019-11-19 Thread Fan, ZhijuX
Hi: regression test: pass build for minplatforms, WhitleyRp, TigerLake functional test: Define a PCD in a dec file (e.g. StandaloneMmPkg.dec) that none of the modules depend on, it is defined in a [PcdsFixedAtBuild] or [PcdsFeatureFlag] section Create the [Packages] section in the DSC file and

Re: [edk2-devel] [PATCH V2] BaseTools:Add [packages] section in dsc file

2019-11-14 Thread Liming Gao
Zhiju: Can you show what test are done for this new support? Thanks Liming >-Original Message- >From: Fan, ZhijuX >Sent: Thursday, November 14, 2019 9:28 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [PATCH V2] BaseTools:Add [packages] section in dsc file > >BZ:h

Re: [edk2-devel] [PATCH V2] BaseTools:Add [packages] section in dsc file

2019-11-13 Thread Bob Feng
This patch looks good. Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Thursday, November 14, 2019 9:28 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V2] BaseTools:Add [packages] section in dsc file BZ:https://bugzilla.tianocore.org/show_bu

[edk2-devel] [PATCH V2] BaseTools:Add [packages] section in dsc file

2019-11-13 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2270 Currently a PCD (e.g. FeaturePCD) cannot be used in a conditional statement in a DSC/FDF file without a module in the build referencing the PCD package DEC file. An example implementation that to support this is to allow a [Packages] section