Re: [edk2-devel] [PATCH V11 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-29 Thread Min Xu
On March 28, 2022 4:25 PM, Ni Ray wrote: > > + CopyMem (ProcessorInfoBuffer, &gTdxProcessorInformation, sizeof > + (EFI_PROCESSOR_INFORMATION)); > > Min, > You may not directly copy the whole structure to ProcessorInfoBuffer. > > Because per the structure definition(below), ExtendedInformation

Re: [edk2-devel] [PATCH V11 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-28 Thread Ni, Ray
+ CopyMem (ProcessorInfoBuffer, &gTdxProcessorInformation, sizeof (EFI_PROCESSOR_INFORMATION)); Min, You may not directly copy the whole structure to ProcessorInfoBuffer. Because per the structure definition(below), ExtendedInformation is only filled when CPU_V2_EXTENDED_TOPOLOGY is set in Pro

[edk2-devel] [PATCH V11 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-28 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In TDVF BSP and APs are simplified. BSP is the vCPU-0, while the others are treated as APs. So MP intialization is rather simple. The processor info is retrieved by TDCALL, ApWorker is not supported, BSP is always the working processor, whi