Re: [edk2-devel] [PATCH V10 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-28 Thread Min Xu
On March 28, 2022 9:20 AM, Ni Ray wrote: > All look good! 3 minor comments: > 1. DxeMpLib.c may not need to include MpIntelTdx.h 2. You may use "ASSERT > (!ExcludeBsp)" in below code. Otherwise, it may confuse reader that when > ExcludeBsp is TRUE, SUCCESS is returned when ProcessorCount is 1 which

Re: [edk2-devel] [PATCH V10 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-27 Thread Ni, Ray
All look good! 3 minor comments: 1. DxeMpLib.c may not need to include MpIntelTdx.h 2. You may use "ASSERT (!ExcludeBsp)" in below code. Otherwise, it may confuse reader that when ExcludeBsp is TRUE, SUCCESS is returned when ProcessorCount is 1 which is not right. if (CC_GUEST_IS_TDX (PcdGet64

[edk2-devel] [PATCH V10 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-23 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In TDVF BSP and APs are simplified. BSP is the vCPU-0, while the others are treated as APs. So MP intialization is rather simple. The processor info is retrieved by TDCALL, ApWorker is not supported, BSP is always the working processor, whi