Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-08 Thread Brijesh Singh via groups.io
On 6/8/21 1:01 PM, Laszlo Ersek via groups.io wrote: > >> Now I think about it maybe we should leave the driver where it is >> because OvmfPkgX64.dsc does not need to deal with the attestation etc. >> But we need to create a driver that can install the EFI configuration >> table for the SNP secre

Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-08 Thread Laszlo Ersek
On 06/08/21 17:43, Brijesh Singh wrote: > > On 6/8/21 4:20 AM, Laszlo Ersek via groups.io wrote: >> >> I thought the secrets page was entirely opaque to the guest firmware; >> i.e., all the guest firmware would do with it is (a) cover it with an >> allocation in SecretPei, (b) forward it to the gu

Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-08 Thread Brijesh Singh via groups.io
On 6/8/21 4:20 AM, Laszlo Ersek via groups.io wrote: > > I thought the secrets page was entirely opaque to the guest firmware; > i.e., all the guest firmware would do with it is (a) cover it with an > allocation in SecretPei, (b) forward it to the guest OS via a UEFI > system config table in Secr

Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-08 Thread Laszlo Ersek
On 06/07/21 19:33, Brijesh Singh wrote: > > On 6/7/21 7:48 AM, Laszlo Ersek wrote: >> On 06/07/21 14:26, Laszlo Ersek wrote: >>> On 05/27/21 01:11, Brijesh Singh wrote: BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D327

Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-08 Thread Laszlo Ersek
On 06/07/21 17:58, Brijesh Singh wrote: > > On 6/7/21 7:26 AM, Laszlo Ersek wrote: >> On 05/27/21 01:11, Brijesh Singh wrote: >>> BZ: >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C32

Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-07 Thread Brijesh Singh via groups.io
On 6/7/21 7:48 AM, Laszlo Ersek wrote: > On 06/07/21 14:26, Laszlo Ersek wrote: >> On 05/27/21 01:11, Brijesh Singh wrote: >>> BZ: >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7Cc7a5

Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-07 Thread Brijesh Singh via groups.io
On 6/7/21 7:26 AM, Laszlo Ersek wrote: > On 05/27/21 01:11, Brijesh Singh wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C32a95d87f0984b88080708d929af878f%7C3dd8961fe4884

Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-07 Thread Laszlo Ersek
On 06/07/21 14:26, Laszlo Ersek wrote: > On 05/27/21 01:11, Brijesh Singh wrote: >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 >> >> When AMD SEV is enabled in the guest VM, a hypervisor need to insert a >> secrets page. > > For pure SEV? > >> >> When SEV-SNP is enabled, the secrets pa

Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-07 Thread Laszlo Ersek
On 05/27/21 01:11, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > When AMD SEV is enabled in the guest VM, a hypervisor need to insert a > secrets page. For pure SEV? > > When SEV-SNP is enabled, the secrets page contains the VM platform > communication keys.

[edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-05-26 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 When AMD SEV is enabled in the guest VM, a hypervisor need to insert a secrets page. When SEV-SNP is enabled, the secrets page contains the VM platform communication keys. The guest BIOS and OS can use this key to communicate with the SEV fi