I see. Will do that.
> -Original Message-
> From: Wang, Jian J
> Sent: Monday, January 6, 2020 1:58 PM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Zhang, Chao B
> Subject: RE: [PATCH 6/6] SecurityPkg/Tcg2Pei: Add TCG PFP 105 support.
>
> I mean putting all rev0 code in 'else' not jus
I mean putting all rev0 code in 'else' not just one line. For rev105, your patch
will initialize FvBlob but never use it at all. It will confuse readers
sometimes.
Regards,
Jian
> -Original Message-
> From: Yao, Jiewen
> Sent: Monday, January 06, 2020 1:53 PM
> To: Wang, Jian J ; devel@
Hi Jian
I purposely put the line there, because I want to group all the rev 0 code
together and rev 105 code together in if statement. I don't want to move that
particular line to else statement.
Thank you
Yao Jiewen
> -Original Message-
> From: Wang, Jian J
> Sent: Monday, January 6,
Jiewen,
Just one minor comment. With it addressed,
Reviewed-by: Jian J Wang
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, December 31, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Zhang, Chao B
>
> Subject: [PATCH 6/6] SecurityPkg/Tcg2Pei: Add TCG PFP 105
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2439
Use EV_EFI_PLATFORM_FIRMWARE_BLOB2 if the TCG PFP revision is >= 105.
Use FvName as the description for the FV.
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Jiewen Yao
---
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 91 ++
