Re: [edk2-devel] [PATCH 24/24] [hack] turn off -Werror

2021-12-08 Thread Gerd Hoffmann
On Fri, Dec 03, 2021 at 04:27:02PM +, Michael D Kinney wrote: > You should be able to undefine MIN at the right place instead of turning off > all warnings as errors. FYI: trying to get that fixed in openssl upstream. https://github.com/openssl/openssl/pull/17219 take care, Gerd -=-=-=

Re: [edk2-devel] [PATCH 24/24] [hack] turn off -Werror

2021-12-05 Thread Gerd Hoffmann
On Fri, Dec 03, 2021 at 06:38:52PM +, Kinney, Michael D wrote: > Hi Pedro, > > If there are specific issues with specific submodules, I would prefer > that we disable only the specific subset of warnings that are > triggered by that one project. Disabling all warnings as errors may > hide way

Re: [edk2-devel] [PATCH 24/24] [hack] turn off -Werror

2021-12-05 Thread Gerd Hoffmann
On Fri, Dec 03, 2021 at 04:27:02PM +, Michael D Kinney wrote: > You should be able to undefine MIN at the right place instead of turning off > all warnings as errors. Not so easy unfortunately. Tried that in CryptoPkg/Library/Include/CrtLibSupport.h (which is the place where all the other #d

Re: [edk2-devel] [PATCH 24/24] [hack] turn off -Werror

2021-12-03 Thread Michael D Kinney
9:58 AM To: edk2-devel-groups-io ; Kinney, Michael D Cc: kra...@redhat.com; Yao, Jiewen ; Wang, Jian J ; Jiang, Guomin ; Pawel Polawski ; Philippe Mathieu-Daudé ; Lu, XiaoyuX Subject: Re: [edk2-devel] [PATCH 24/24] [hack] turn off -Werror Mike, If I get the patch right, it's working aro

Re: [edk2-devel] [PATCH 24/24] [hack] turn off -Werror

2021-12-03 Thread Pedro Falcato
Friday, December 3, 2021 8:08 AM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen ; Wang, Jian J < > jian.j.w...@intel.com>; Jiang, Guomin ; > > Pawel Polawski ; Philippe Mathieu-Daudé < > phi...@redhat.com>; Lu, XiaoyuX ; Gerd > > Hoffmann > > Subject: [

Re: [edk2-devel] [PATCH 24/24] [hack] turn off -Werror

2021-12-03 Thread Michael D Kinney
; Wang, Jian J ; > Jiang, Guomin ; > Pawel Polawski ; Philippe Mathieu-Daudé > ; Lu, XiaoyuX ; Gerd > Hoffmann > Subject: [edk2-devel] [PATCH 24/24] [hack] turn off -Werror > > workaround for this: > CryptoPkg/Library/OpensslLib/openssl/providers/implementations/kdfs/

[edk2-devel] [PATCH 24/24] [hack] turn off -Werror

2021-12-03 Thread Gerd Hoffmann
workaround for this: CryptoPkg/Library/OpensslLib/openssl/providers/implementations/kdfs/kbkdf.c:49: warning: "MIN" redefined Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Library/