Will change the commit based on the comments.
Thanks,
Dun
-Original Message-
From: Ni, Ray
Sent: Wednesday, December 6, 2023 5:24 PM
To: Tan, Dun ; devel@edk2.groups.io
Cc: Dong, Eric ; Kumar, Rahul R ;
Gerd Hoffmann
Subject: RE: [PATCH 2/6] UefiCpuPkg: Build MpInfo2HOB in CpuMpPei
4
4 minor comments:
> +DEBUG ((DEBUG_INFO, "BuildMpInformationHob\n"));
1. DEBUG ("Creating MpInformation2 HOB...\n")
> +
> +for (Index = 0; Index < NumberOfProcessorsInHob; Index++) {
> + MpInformation2Entry = GET_MP_INFORMATION_ENTRY
> (MpInformation2HobData, Index);
2. Since Entry
Build MpInfo2HOB in CpuMpPei module so that later
PiSmmCpuDxe or other StandaloneMm module can consume
the HOB.
Since there might be more one gMpInformationHobGuid2
in HOB list, CpuMpPei create a gMpInformationHobGuid2
with 0 value NumberOfProcessors field in the end of the
process to indicate it's