Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-04-02 Thread Patrick Rudolph
for the platform developer. > > > > > > Thanks > > > Liming > > >> -邮件原件- > > >> 发件人: devel@edk2.groups.io 代表 Marvin > > >> H?user > > >> 发送时间: 2023年3月28日 19:26 > > >> 收件人: gaoliming > > >> 抄送

回复: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-04-02 Thread gaoliming via groups.io
@9elements.com; > guo.d...@intel.com; gua@intel.com; james...@intel.com; > ray...@intel.com; a...@kernel.org > 主题: Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix > CLANGDWARF_IA32_X64 > > Liming, > > Platform maintainers can decide whether or not they want to combat

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-31 Thread Marvin Häuser
> On 31. Mar 2023, at 16:41, Ni, Ray wrote: > > Why ELF header overflows into .text section? That's a good question, isn't it? :) >From what I can see, these binaries don't pass post-processing like GenFw or >such. GCC (and I think thus CLANGDWARF?) gets an extra objcopy step as part of >lin

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-31 Thread Ni, Ray
Why ELF header overflows into .text section? > -Original Message- > From: Patrick Rudolph > Sent: Friday, March 17, 2023 10:06 PM > Cc: devel@edk2.groups.io; Dong, Guo ; Guo, Gua > ; Lu, James ; Ni, Ray > ; mhaeu...@posteo.de; a...@kernel.org > Subject: [PATCH 2/3] BaseTools/Conf/tools_de

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-31 Thread Marvin Häuser
om; james...@intel.com; >> ray...@intel.com; a...@kernel.org >> 主题: Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix >> CLANGDWARF_IA32_X64 >> >> Hi all, >> >>>> On 28. Mar 2023, at 07:38, gaoliming wrote: >>> Patrick: &

回复: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-30 Thread gaoliming via groups.io
ng > 抄送: devel@edk2.groups.io; patrick.rudo...@9elements.com; > guo.d...@intel.com; gua@intel.com; james...@intel.com; > ray...@intel.com; a...@kernel.org > 主题: Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix > CLANGDWARF_IA32_X64 > > Hi all, > > >

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-28 Thread Marvin Häuser
l.com; gua@intel.com; >> james...@intel.com; ray...@intel.com; mhaeu...@posteo.de; >> a...@kernel.org >> 主题: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix >> CLANGDWARF_IA32_X64 >> >> Drop the "-z max-page-size=0x40" option as it causes the ELF &

回复: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-27 Thread gaoliming via groups.io
org > 主题: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix > CLANGDWARF_IA32_X64 > > Drop the "-z max-page-size=0x40" option as it causes the ELF > header to overflow into the .text section, causing undefined > behaviour. > > With high optimization level it c

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-26 Thread Sheng Lean Tan
Added @rebe...@bsdio.com as well. On Sun, 26 Mar 2023 at 21:39, Sheng Lean Tan via groups.io wrote: > Can someone also help to review this please? > Thanks. > > > On Fri, 17 Mar 2023 at 15:06, Patrick Rudolph < > patrick.rudo...@9elements.com> wrote: > >> Drop the "-z max-page-size=0x40" optio

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-26 Thread Sheng Lean Tan
Can someone also help to review this please? Thanks. On Fri, 17 Mar 2023 at 15:06, Patrick Rudolph wrote: > Drop the "-z max-page-size=0x40" option as it causes the ELF > header to overflow into the .text section, causing undefined > behaviour. > > With high optimization level it corrupts essen

[edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-17 Thread Patrick Rudolph
Drop the "-z max-page-size=0x40" option as it causes the ELF header to overflow into the .text section, causing undefined behaviour. With high optimization level it corrupts essential code and the binary would crash. It might work with low optimization level though. As the default is to use Oz and

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-15 Thread Sheng Lean Tan
adding the right reviewers. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101238): https://edk2.groups.io/g/devel/message/101238 Mute This Topic: https://groups.io/mt/97421037/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: ht

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-06 Thread Sean Rhodes
Reviewed-by: Sean Rhodes On Mon, 6 Mar 2023 at 08:38, Patrick Rudolph wrote: > Drop the "-z max-page-size=0x40" option as it causes the ELF > header to overflow into the .text section, causing undefined > behaviour. > > With high optimization level it corrupts essential code and > the binary wo

[edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

2023-03-06 Thread Patrick Rudolph
Drop the "-z max-page-size=0x40" option as it causes the ELF header to overflow into the .text section, causing undefined behaviour. With high optimization level it corrupts essential code and the binary would crash. It might work with low optimization level though. As the default is to use Oz and