On Thu, Nov 30, 2023 at 9:31 PM Kinney, Michael D
wrote:
>
> Hi Pedro,
>
> I agree that silent failures are terrible.
>
> The issue is documented with the requirement to use #include here:
>
> https://github.com/tianocore/edk2/tree/master/UnitTestFrameworkPkg#googletest-configuration
>
> Unit test
t; To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Savva Mitrofanov ; Gao, Liming
> ; Liu, Zhiguang
> Subject: Re: [edk2-devel] [PATCH 2/2] MdePkg/Test: Add google tests for
> BaseLib
>
> On Thu, Nov 30, 2023 at 7:32 PM Michael D Kinney
> wrote:
> >
> > With on
On Thu, Nov 30, 2023 at 7:32 PM Michael D Kinney
wrote:
>
> With one comment below addressed
>
> Reviewed-by: Michael D Kinney
>
> > -Original Message-
> > From: Pedro Falcato
> > Sent: Wednesday, November 29, 2023 6:46 PM
> > To: devel@edk2.groups.io
> > Cc: Savva Mitrofanov ; Pedro Fal
With one comment below addressed
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Pedro Falcato
> Sent: Wednesday, November 29, 2023 6:46 PM
> To: devel@edk2.groups.io
> Cc: Savva Mitrofanov ; Pedro Falcato
> ; Gao, Liming ; Kinney,
> Michael D ; Liu, Zhiguang
>
> Subject: [P
Add GoogleTestBaseLib, which contains gtest unit tests for BaseLib.
For now, only add checksum tests for CRC32C and CRC16; these tests check
for correctness on various inputs using precomputed hashes.
Signed-off-by: Pedro Falcato
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Zhiguang Liu
---
.../Li
