Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

Subject: [EXTERNAL] Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies I’m reading between the lines a little bit… but it seems like your response amounts to: Acked-by: Bret Barkelew Which I added to the commit: https://github.com/tianocore/edk2-staging

Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

I’m reading between the lines a little bit… but it seems like your response amounts to: Acked-by: Bret Barkelew Which I added to the commit: https://github.com/tianocore/edk2-staging/commit/79ba022e Hope that’s cool 😊. From: Bret Barkelew Sent: Friday, March 20, 2020 3:07 PM To: Desimone, A

Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

Spiffy. Agreed; thanks for the background. My only other concern would be the function name and if some future developer thought that was permission to add other modules to it. Then again, maybe I’m just bikeshedding. Feel free to ignore. - Bret From: Desimone, Ashley E

Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

Thanks for the explanation. Reviewed-by: Ashley DeSimone From: Desimone, Nathaniel L Sent: Thursday, March 19, 2020 2:01 PM To: Bret Barkelew ; Desimone, Ashley E ; devel@edk2.groups.io Cc: Pandya, Puja ; Bjorge, Erik C Subject: Re: [PATCH 1/4] EdkRepo: Installer should remove obsolete depen

Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

Hi Bret, I alluded to this a little bit in the cover letter, completely agreed a more detailed explanation is needed. There is an odd situation with the way GitPython’s dependencies are evolved over time. Initially, they had the following dependency graph: * GitPython * gitdb

Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

Naïve question: why isn’t this upgrade handled when pip installs the new wheel? Are the dependencies not matched up correctly? I would think that pip would uninstall the old version on its own. - Bret From: Desimone, Ashley E Sent: Thursday, March 19, 2020 12

Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

For the following section why are we singling out gitdb2 and smmap2 when deleting obsolete dependencies? Is there an alternative to hardcoding these values? +if (DeleteObsoletePackages) +{ +// +// Delete obsolete dependencie

[edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Signed-off-by: Nate DeSimone --- .../EdkRepoInstaller/InstallWorker.cs | 30 +- edkrepo_installer/linux-scripts/install.py| 58 --- 2 files changed, 66 insertions(+), 22 deletions(-) dif