Re: [edk2-devel] [PATCH 1/3] UefiPayloadPkg: Simplify code logic

2022-05-10 Thread Zhiguang Liu
Hi Ray, The function DetectAndPreparePlatformPciDevicePath is the second parameter of VisitAllInstancesOfProtocol. It follows the below type: typedef EFI_STATUS (EFIAPI *PROTOCOL_INSTANCE_CALLBACK)( IN EFI_HANDLEHandle, IN VOID *Instance, IN VOID *

Re: [edk2-devel] [PATCH 1/3] UefiPayloadPkg: Simplify code logic

2022-05-10 Thread Ni, Ray
> > +DetectAndPreparePlatformPciDevicePath ( > >IN EFI_HANDLE Handle, > >IN VOID*Instance, > >IN VOID*Context Is "Context" needed? Can you please remove it? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (

[edk2-devel] [PATCH 1/3] UefiPayloadPkg: Simplify code logic

2022-05-10 Thread Zhiguang Liu
A little overdesign about VisitAllPciInstances function, since there are two call back functions. Simplify the code logic by combining the two call back functions. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Zhiguang Liu --- .../PlatformBootManager