Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: Add support for ARMv8.5 RNG instructions

2021-05-04 Thread Rebecca Cran
On 5/4/21 3:06 PM, Sami Mujawar wrote: +#if defined (MDE_CPU_AARCH64) + +/** +  Reads the ID_AA64ISAR0 Register. + +  @return The contents of the ID_AA64ISAR0 Register + +**/ +UINT64 +EFIAPI +ArmReadIdIsar0 ( +  VOID +  ); + [SAMI] Should this function be part of ArmLib? [/SAMI] It's currentl

Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: Add support for ARMv8.5 RNG instructions

2021-05-04 Thread Sami Mujawar
Hi Rebecca, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/04/2021 09:44 PM, Rebecca Cran wrote: Add support for the optional ARMv8.5 RNDR and RNDRRS instructions that are a part of FEAT_RNG to BaseLib, and add a function to read the ISAR0 register which indicates

[edk2-devel] [PATCH 1/3] MdePkg/BaseLib: Add support for ARMv8.5 RNG instructions

2021-04-28 Thread Rebecca Cran
Add support for the optional ARMv8.5 RNDR and RNDRRS instructions that are a part of FEAT_RNG to BaseLib, and add a function to read the ISAR0 register which indicates whether the CPU supports FEAT_RNG. Signed-off-by: Rebecca Cran --- MdePkg/Library/BaseLib/BaseLib.inf| 4 ++ Md