Re: [edk2-devel] [PATCH 1/2 v4] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-02-12 Thread Ilias Apalodimas
Thanks Sami, I managed to run Ecc properly now, so it already reported that to me On Fri, 12 Feb 2021 at 17:29, Sami Mujawar wrote: > > Hi Ilias, > > > +#ifndef OPTEE_RPMB_FVB_H > > +#define OPTEE_RPMB_FVB_H > Just remembered the include file guard should be 'OPTEE_RPMB_FVB_H_' in > Drivers/OpT

Re: [edk2-devel] [PATCH 1/2 v4] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-02-12 Thread Sami Mujawar
Hi Ilias, > +#ifndef OPTEE_RPMB_FVB_H > +#define OPTEE_RPMB_FVB_H Just remembered the include file guard should be 'OPTEE_RPMB_FVB_H_' in Drivers/OpTeeRpmb/OpTeeRpmbFvb.h Regards, Sami Mujawar -Original Message- From: Ilias Apalodimas Sent: 12 February 2021 01:38 PM To: Sami Mujawar

Re: [edk2-devel] [PATCH 1/2 v4] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-02-12 Thread Ilias Apalodimas
Hi Sami, On Fri, Feb 12, 2021 at 01:11:10PM +, Sami Mujawar wrote: > Hi Ilias, > > Apologies for the delay in reviewing this patch. > No worries, thanks for the comments > Please find my response inline marked [SAMI]. > There are some coding standard issues remaining. I believe these are

Re: [edk2-devel] [PATCH 1/2 v4] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-02-12 Thread Sami Mujawar
Hi Ilias, Apologies for the delay in reviewing this patch. Please find my response inline marked [SAMI]. There are some coding standard issues remaining. I believe these are not reported by Ecc. Also, InitializeFvAndVariableStoreHeaders() would need error handling for a memory allocation failu

[edk2-devel] [PATCH 1/2 v4] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

2021-02-03 Thread Ilias Apalodimas
A following patch is adding support for building StMM in order to run it from OP-TEE. OP-TEE in combination with a NS-world supplicant can use the RPMB partition of an eMMC to store EFI variables. The supplicant functionality is currently available in U-Boot only but can be ported into EDK2. Assumi