Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg: Simplify InitializeSeparateExceptionStacks

2022-08-03 Thread Ni, Ray
1. Old code contains a picture that describes the buffer layout. It seems the picture disappears in new code. 2. When TSS is enabled, there is one descriptor in GDT that points to the TSS. But TSS is not part of GDT. New code contains comments to treat TSS as part of GDT. 3. Did you run ECC and

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg: Simplify InitializeSeparateExceptionStacks

2022-07-22 Thread Sami Mujawar
Hi Zhiguan, TheĀ  ArmPkg/Library/* changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 22/07/2022 08:57 am, Zhiguang Liu wrote: Hide the Exception implementation details in CpuExcetionHandlerLib and caller only need to provide buffer Cc: Eric Dong Cc: Ray Ni Cc: Ra

[edk2-devel] [PATCH 1/2] UefiCpuPkg: Simplify InitializeSeparateExceptionStacks

2022-07-22 Thread Zhiguang Liu
Hide the Exception implementation details in CpuExcetionHandlerLib and caller only need to provide buffer Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Leif Lindholm Cc: Dandan Bi Cc: Liming Gao Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Zhiguang Liu --- .../Libra