Re: [edk2-devel] [PATCH 1/2] MdePkg/UefiDevicePathLib: Separate the device path lib

2019-12-10 Thread Gao, Zhichao
The mandatory one is expected to catch the ASSERT. But the Optional one should return success. I would fix that in the V2 patch set. Thanks, Zhichao > -Original Message- > From: Gao, Liming > Sent: Tuesday, December 10, 2019 9:04 AM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Kinney

Re: [edk2-devel] [PATCH 1/2] MdePkg/UefiDevicePathLib: Separate the device path lib

2019-12-09 Thread Liming Gao
Zhichao: The change is good. New library instance is benefit for image size. But, please make sure library constructor always return success. Otherwise, error status will assert in autogen code. Thanks Liming >-Original Message- >From: Gao, Zhichao >Sent: Thursday, November 28, 201

[edk2-devel] [PATCH 1/2] MdePkg/UefiDevicePathLib: Separate the device path lib

2019-11-27 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2298 UefiDevicePathLibOptionalDevicePathProtocol's implementation isn't fit its description. It should be implement as blow: Try to find the DevicePathProtocol, if found then use it to implement the interface. Else, use the local interface. It sh