Re: [edk2-devel] [PATCH 1/2] MdePkg/BaseLib: Fix CRC16-ANSI calculation

2023-11-30 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Pedro Falcato > Sent: Wednesday, November 29, 2023 6:46 PM > To: devel@edk2.groups.io > Cc: Savva Mitrofanov ; Pedro Falcato > ; Gao, Liming ; Kinney, > Michael D ; Liu, Zhiguang > > Subject: [PATCH 1/2] MdePkg/BaseLib: Fix CRC1

[edk2-devel] [PATCH 1/2] MdePkg/BaseLib: Fix CRC16-ANSI calculation

2023-11-29 Thread Pedro Falcato
The current CalculateCrc16Ansi implementation does the following: 1) Invert the passed checksum 2) Calculate the new checksum by going through data and using the lookup table 3) Invert it back again This emulated my design for CalculateCrc32c, where 0 is passed as the initial checksum, and it i