Re: [edk2-devel] [PATCH 1/2] Ext4Pkg: Improve Binding support behavior

Good day, On 09/09/2021 22:41, Jeff Brasen via groups.io wrote: A couple improvements to improve performance. Add check to return ACCESS_DENIED if already connected This "performance improvement" actually aligns the load behaviour with the UEFI spec, maybe it should be mentioned? Add check

Re: [edk2-devel] [PATCH 1/2] Ext4Pkg: Improve Binding support behavior

Sounds good will update that in a v2 patch tomorrow Get Outlook for Android From: Pedro Falcato Sent: Thursday, September 9, 2021 10:22:51 PM To: Jeff Brasen Cc: edk2-devel-groups-io Subject: Re: [PATCH 1/2] Ext4Pkg: Improve Binding suppor

Re: [edk2-devel] [PATCH 1/2] Ext4Pkg: Improve Binding support behavior

Hi Jeff, Comments below. The patch itself looks good. Nitpick on the commit message: I'd reword the commit message to something like "Improve Ext4IsBindingSupported() behavior" or "Improve IsBindingSupported behavior", since this patch doesn't change Ext4Bind(), which does the actual bind. On T

[edk2-devel] [PATCH 1/2] Ext4Pkg: Improve Binding support behavior

A couple improvements to improve performance. Add check to return ACCESS_DENIED if already connected Add check to verify superblock magic during supported to deduce start calls Signed-off-by: Jeff Brasen --- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h| 14 +++ Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c