Re: [edk2-devel] [PATCH 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-14 Thread Ashish Singhal via groups.io
Hello Abner, Thanks for the feedback. I have pushed v2 of the patch set. Thanks Ashish From: Chang, Abner Sent: Thursday, November 9, 2023 7:06 PM To: Ashish Singhal ; devel@edk2.groups.io ; quic_llind...@quicinc.com ; ardb+tianoc...@kernel.org ; g...@danielsch

Re: [edk2-devel] [PATCH 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-09 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] From: Ashish Singhal Sent: Tuesday, November 7, 2023 1:55 AM To: devel@edk2.groups.io; quic_llind...@quicinc.com; ardb+tianoc...@kernel.org; Chang, Abner ; g...@danielschaefer.me; Jeff Brasen Subject: Re: [PATCH 1/2] EmbeddedPkg: Fix Android Boot Command Lin

Re: [edk2-devel] [PATCH 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-11-06 Thread Ashish Singhal via groups.io
Hello, Hoping to get some feedback on these 2 patches this week. Thanks Ashish From: Ashish Singhal Sent: Monday, October 30, 2023 2:24 PM To: devel@edk2.groups.io ; quic_llind...@quicinc.com ; ardb+tianoc...@kernel.org ; abner.ch...@amd.com ; g...@danielschae

[edk2-devel] [PATCH 1/2] EmbeddedPkg: Fix Android Boot Command Line Length Bug

2023-10-30 Thread Ashish Singhal via groups.io
Curently, AndroidBootImgLib expects input kernel command line to never exceed 256 unicode characters where the image header allows for 512 ascii characters. If image header allows 512 ascii characters, similar number of unicode characters should be allowed at the minimum. Signed-off-by: Ashish Sin