Re: [edk2-devel] [PATCH 1/1] OvmfPkg: fix PcdFSBClock

2022-05-25 Thread Yao, Jiewen
iming > > Sent: Wednesday, May 25, 2022 9:43 AM > > To: devel@edk2.groups.io; kra...@redhat.com > > Cc: 'Pawel Polawski' ; 'Oliver Steffen' > > ; 'Laszlo Ersek' > > Subject: 回复: [edk2-devel] [PATCH 1/1] OvmfPkg: fix PcdFSBClock > > &g

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: fix PcdFSBClock

2022-05-24 Thread Gerd Hoffmann
Hi, > By the way: "kvm FSB clock is 1GHz" -- where is that constant set in > KVM? > > ... is it "target/i386/kvm/kvm.c" in QEMU: > > > /* From arch/x86/kvm/lapic.h */ > > #define KVM_APIC_BUS_CYCLE_NS 1 > > #define KVM_APIC_BUS_FREQUENCY (10ULL / KVM_APIC_BUS_CYCLE_NS) > >

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: fix PcdFSBClock

2022-05-24 Thread Yao, Jiewen
Polawski' ; 'Oliver Steffen' > ; 'Laszlo Ersek' > Subject: 回复: [edk2-devel] [PATCH 1/1] OvmfPkg: fix PcdFSBClock > > Gerd: > I am OK to merge this bug fix for stable tag 202205 once this patch passes > code review. > > Thanks > Liming > > ---

回复: [edk2-devel] [PATCH 1/1] OvmfPkg: fix PcdFSBClock

2022-05-24 Thread gaoliming
i ; Oliver Steffen > ; Laszlo Ersek > 主题: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: fix PcdFSBClock > > On Mon, May 23, 2022 at 03:45:04PM +0200, Gerd Hoffmann wrote: > > kvm FSB clock is 1GHz, not 100 MHz. Timings are off by factor 10. > > Fix all affected build configurations.

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: fix PcdFSBClock

2022-05-24 Thread Laszlo Ersek
On 05/23/22 15:45, Gerd Hoffmann wrote: > kvm FSB clock is 1GHz, not 100 MHz. Timings are off by factor 10. > Fix all affected build configurations. Not changed: Microvm and > Cloudhw (they have already have the correct value), and Xen (has > no fixed frequency, the PCD is configured at runtime b

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: fix PcdFSBClock

2022-05-23 Thread Gerd Hoffmann
On Mon, May 23, 2022 at 03:45:04PM +0200, Gerd Hoffmann wrote: > kvm FSB clock is 1GHz, not 100 MHz. Timings are off by factor 10. > Fix all affected build configurations. Not changed: Microvm and > Cloudhw (they have already have the correct value), and Xen (has > no fixed frequency, the PCD is

[edk2-devel] [PATCH 1/1] OvmfPkg: fix PcdFSBClock

2022-05-23 Thread Gerd Hoffmann
kvm FSB clock is 1GHz, not 100 MHz. Timings are off by factor 10. Fix all affected build configurations. Not changed: Microvm and Cloudhw (they have already have the correct value), and Xen (has no fixed frequency, the PCD is configured at runtime by platform initialization code). Fixes: c37cbc0