Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

2023-10-18 Thread Laszlo Ersek
On 10/18/23 15:13, Gerd Hoffmann wrote: > Hi, > >>> - if (!VirtioFsFile->IsDirectory) { >>> + if (!VirtioFsFile->IsDirectory && FileName[0] != '\\') { > >> It's nice to see this topic pop up on edk2-devel; apparently you started >> testing shim on top of virtio-fs. :) > > Indeed. For starte

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

2023-10-18 Thread Laszlo Ersek
On 10/18/23 15:08, Pedro Falcato wrote: > On Wed, Oct 18, 2023 at 1:20 PM Laszlo Ersek wrote: >> >> On 10/18/23 13:33, Pedro Falcato wrote: >>> On Wed, Oct 18, 2023 at 12:20 PM Laszlo Ersek wrote: On 10/18/23 12:33, Gerd Hoffmann wrote: > VirtiofsDxe throws an error in case the call

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

2023-10-18 Thread Gerd Hoffmann
Hi, > > - if (!VirtioFsFile->IsDirectory) { > > + if (!VirtioFsFile->IsDirectory && FileName[0] != '\\') { > It's nice to see this topic pop up on edk2-devel; apparently you started > testing shim on top of virtio-fs. :) Indeed. For starters just passed the host /boot/efi into the guest to

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

2023-10-18 Thread Pedro Falcato
On Wed, Oct 18, 2023 at 1:20 PM Laszlo Ersek wrote: > > On 10/18/23 13:33, Pedro Falcato wrote: > > On Wed, Oct 18, 2023 at 12:20 PM Laszlo Ersek wrote: > >> > >> On 10/18/23 12:33, Gerd Hoffmann wrote: > >>> VirtiofsDxe throws an error in case the caller tries to open a file or > >>> directory u

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

2023-10-18 Thread Laszlo Ersek
On 10/18/23 13:33, Pedro Falcato wrote: > On Wed, Oct 18, 2023 at 12:20 PM Laszlo Ersek wrote: >> >> On 10/18/23 12:33, Gerd Hoffmann wrote: >>> VirtiofsDxe throws an error in case the caller tries to open a file or >>> directory using an handle with is not a directory, claiming that opening >>> s

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

2023-10-18 Thread Pedro Falcato
On Wed, Oct 18, 2023 at 12:20 PM Laszlo Ersek wrote: > > On 10/18/23 12:33, Gerd Hoffmann wrote: > > VirtiofsDxe throws an error in case the caller tries to open a file or > > directory using an handle with is not a directory, claiming that opening > > something relative to a file does not make se

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

2023-10-18 Thread Laszlo Ersek
On 10/18/23 12:33, Gerd Hoffmann wrote: > VirtiofsDxe throws an error in case the caller tries to open a file or > directory using an handle with is not a directory, claiming that opening > something relative to a file does not make sense. > > The claim is correct, but the code throws errors for bo

[edk2-devel] [PATCH 1/1] OvmfPkg/VirtioFsDxe: fix SimpleFileOpen

2023-10-18 Thread Gerd Hoffmann
VirtiofsDxe throws an error in case the caller tries to open a file or directory using an handle with is not a directory, claiming that opening something relative to a file does not make sense. The claim is correct, but the code throws errors for both relative and absolute paths. Add a check to f