Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test.

2020-02-17 Thread Ard Biesheuvel
On Mon, 17 Feb 2020 at 08:31, Gaurav Jain wrote: > > ASSERT in SetTime_Conf and SetWakeupTime_Conf Consistency Test. > SCT Test expect return as Invalid Parameter. > So removed ASSERT(). > > Added Time Validity Checks in SetWakeupTime. > > Signed-off-by: Gaurav Jain If this is a followup that su

[edk2-devel] [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test.

2020-02-16 Thread Gaurav Jain
ASSERT in SetTime_Conf and SetWakeupTime_Conf Consistency Test. SCT Test expect return as Invalid Parameter. So removed ASSERT(). Added Time Validity Checks in SetWakeupTime. Signed-off-by: Gaurav Jain --- EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 8 1 file changed, 4 inser

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test.

2020-01-30 Thread Ard Biesheuvel
On Thu, 30 Jan 2020 at 06:08, Gaurav Jain wrote: > > ASSERT in SetTime_Conf and SetWakeupTime_Conf Consistency Test. > SCT Test expect return as Invalid Parameter. > So removed ASSERT(). > This is not all this patch does. > Signed-off-by: Gaurav Jain > --- > EmbeddedPkg/RealTimeClockRuntimeDxe

[edk2-devel] [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test.

2020-01-29 Thread Gaurav Jain
ASSERT in SetTime_Conf and SetWakeupTime_Conf Consistency Test. SCT Test expect return as Invalid Parameter. So removed ASSERT(). Signed-off-by: Gaurav Jain --- EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Em