Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-09-03 Thread Nhi Pham via groups.io
Hi Abner, Thank you so much for reviewing this patch. On 22/08/2021 21:42, Chang, Abner (HPS SW/FW Technologist) wrote: Hi Pham, First at all, you have to update the copyright. Other comments are in below, Will update. -Original Message- From: Nhi Pham [mailto:n...@os.amperecomputing.

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-09-03 Thread Nhi Pham via groups.io
Hi Abner, Thank you so much for reviewing this patch. On 22/08/2021 21:42, Chang, Abner (HPS SW/FW Technologist) wrote: Hi Pham, First at all, you have to update the copyright. Other comments are in below, Will update. -Original Message- From: Nhi Pham [mailto:n...@os.amperecomputin

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-08-22 Thread Abner Chang
Hi Pham, First at all, you have to update the copyright. Other comments are in below, > -Original Message- > From: Nhi Pham [mailto:n...@os.amperecomputing.com] > Sent: Tuesday, August 17, 2021 9:24 PM > To: devel@edk2.groups.io > Cc: patc...@amperecomputing.com; Nhi Pham > ; Leif Lindholm

[edk2-devel] [PATCH 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-08-17 Thread Nhi Pham via groups.io
This adds more helper functions that assist in calculating the checksum, locating an ACPI table by signature, and updating an AML integer object. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Nhi Pham --- EmbeddedPkg/Library/AcpiLib/AcpiLib.inf | 2