Re: [edk2-devel] [PATCH 1/1] BaseTools:Add the spare space FV image size checker

2020-04-02 Thread Sean via groups.io
Not sure I follow.  The changes are in BaseTools/Source/Python/GenFds/GenFds.py I am suggesting this functionality to be written outside the GenFds.py files so that we don't add complexity to the critical tools used for building and packaging FW binaries. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links:

Re: [edk2-devel] [PATCH 1/1] BaseTools:Add the spare space FV image size checker

2020-04-02 Thread Fan, ZhijuX
] BaseTools:Add the spare space FV image size checker I would have much rather seen this implemented independent of the GenFds tool as this is a nice feature but shouldn't be tightly coupled into the tool that does building and packaging firmware. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receiv

Re: [edk2-devel] [PATCH 1/1] BaseTools:Add the spare space FV image size checker

2020-04-02 Thread Sean via groups.io
I would have much rather seen this implemented independent of the GenFds tool as this is a nice feature but shouldn't be tightly coupled into the tool that does building and packaging firmware. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Onli

[edk2-devel] [PATCH 1/1] BaseTools:Add the spare space FV image size checker

2020-04-02 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2654 If FV is placed in FD region, its FV image size is fixed. When FV image size exceeds it, it will trig the build break. To alert the developer to adjust FV image size earlier, I request to add new checker for the the spare FV space. When the s