Re: [edk2-devel] [PATCH 02/11] OvmfPkg: add ShellLibs.dsc.inc

2024-01-26 Thread Gerd Hoffmann
Hi, > My preferred style is observed for example in: > > - NetworkPkg/NetworkLibs.dsc.inc > - RedfishPkg/RedfishLibs.dsc.inc > > Alas, it is not observed in: > > - MdePkg/MdeLibs.dsc.inc > - OvmfPkg/Include/Dsc/OvmfTpmLibs.dsc.inc > > At least, from the last two, OvmfTpmLibs.dsc.inc has an e

Re: [edk2-devel] [PATCH 02/11] OvmfPkg: add ShellLibs.dsc.inc

2024-01-25 Thread Laszlo Ersek
I have several comments on this one: On 1/24/24 17:37, Gerd Hoffmann wrote: > Move EFI Shell libraries from OvmfPkgX64.dsc to > the new ShellComponents.dsc.inc include file. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Include/Dsc/ShellLibs.dsc.inc | 11 +++ > OvmfPkg/OvmfPkgX64.dsc

[edk2-devel] [PATCH 02/11] OvmfPkg: add ShellLibs.dsc.inc

2024-01-24 Thread Gerd Hoffmann
Move EFI Shell libraries from OvmfPkgX64.dsc to the new ShellComponents.dsc.inc include file. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Include/Dsc/ShellLibs.dsc.inc | 11 +++ OvmfPkg/OvmfPkgX64.dsc| 11 +-- 2 files changed, 16 insertions(+), 6 deletions(-) create