0 8:35 AM
> To: Kinney, Michael D ; Fu, Siyuan
> ; devel@edk2.groups.io; Gao, Zhichao
> ; Matthew Carlson ; Sean
> Brogan
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Maciej Rabeda ; Wu, Jiaxin
>
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function
>
thew Carlson
> ; Sean Brogan
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Maciej Rabeda ; Wu, Jiaxin
>
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function
>
> Hi,
>
> I would prefer we only extend the protocol interface and
> never remove any fields
J ; Lu, XiaoyuX
> ; Maciej Rabeda
> ; Wu, Jiaxin
>
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire
> the deprecate function
>
> Jiewen,
>
> Same as you. I prefer update version (#1) for adding API,
> and change
> protocol GUID (#2)for deprecate unsecure A
o; Gao, Zhichao
>
> Cc: Wang, Jian J ; Lu, XiaoyuX
> ; Maciej Rabeda ;
> Wu, Jiaxin
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate
> function
>
> Thanks Siyuan.
> Good, then I think we are aligned.
> I agree with you that it is bad exam
M
> To: Yao, Jiewen ; Kinney, Michael D
> ; devel@edk2.groups.io; Gao, Zhichao
>
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Maciej Rabeda ; Wu, Jiaxin
>
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function
>
> Hi, Jiewen
>
> I agree w
:43
> To: Kinney, Michael D ; devel@edk2.groups.io;
> Fu, Siyuan ; Gao, Zhichao
> Cc: Wang, Jian J ; Lu, XiaoyuX
> ; Maciej Rabeda ;
> Wu, Jiaxin
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate
> function
>
> Thanks Mike.
> I understand the *
e an
> > algorithm, the interface can be unchanged.
> > Just the internal implementation can be changed.
> > The current PCD mechanism can still be applied to
> > internal implementation.
> >
> > Can we get a chance to revisit/redesign the protocol API,
> > w
ay, March 26, 2020 9:59 PM
> To: Fu, Siyuan ;
> devel@edk2.groups.io; Gao, Zhichao
>
> Cc: Wang, Jian J ; Lu, XiaoyuX
> ; Maciej Rabeda
> ; Wu, Jiaxin
>
> Subject: Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire
> the deprecate function
>
> Thanks Siyun.
> I
in
> Subject: Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function
>
> Library is static interface. Protocol is dynamic interface. That is key
> difference.
>
> My understanding for a *private protocol* is that: one module in the package
> to produce. The other
e can change.
> > If we cannot change, it is not private.
> >
> > Thank you
> > Yao Jiewen
> >
> > > -----Original Message-
> > > From: Fu, Siyuan
> > > Sent: Friday, March 27, 2020 1:43 PM
> > > To: Yao, Jiewen ; devel@edk2.g
yuan
> -Original Message-
> From: Yao, Jiewen
> Sent: 2020年3月27日 13:51
> To: Fu, Siyuan ; devel@edk2.groups.io; Gao, Zhichao
>
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Maciej Rabeda ; Wu, Jiaxin
>
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecat
axin
>
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function
>
> Jiewen,
>
> I agree "abstract action not algorithm" is a good design principle, but I'm
> not
> sure
> If there is any plan to move this protocol to the public i
o
>
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Maciej Rabeda ; Wu, Jiaxin
>
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function
>
> Thanks Siyun.
> I think probably we need discuss this more.
>
> 1) About private v.s. public.
>
> The
j Rabeda ; Wu, Jiaxin
>
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function
>
> Hi, Jiewen
>
> Although the protocol is private, a corresponding BaseCryptoLib instance is
> not private, like PeiCryptLib.inf, RuntimeCryptLib, etc. These library
> inst
ssage-
> > From: devel@edk2.groups.io On Behalf Of Siyuan, Fu
> > Sent: Friday, March 27, 2020 10:47 AM
> > To: Gao, Zhichao ; devel@edk2.groups.io
> > Cc: Wang, Jian J ; Lu, XiaoyuX
> ;
> > Maciej Rabeda ; Wu, Jiaxin
> >
> > Subject: Re: [edk2-devel]
; devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Maciej Rabeda ; Wu, Jiaxin
>
> Subject: Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function
>
> Hi, Zhichao
>
> We should never move/delete a member field of a previous defined protocol
>
oyuX
> ; Maciej Rabeda ;
> Wu, Jiaxin ; Fu, Siyuan
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate
> function
>
> The SHA1 is called explicitly in SecurityPkg. Are you sure we don't need
> update security pkg?
>
> > -Original Message---
half Of Yao,
> > Jiewen
> > Sent: Friday, March 27, 2020 10:01 AM
> > To: devel@edk2.groups.io; Gao, Zhichao
> > Cc: Wang, Jian J ; Lu, XiaoyuX
> > ; Maciej Rabeda ;
> > Wu, Jiaxin ; Fu, Siyuan
> > Subject: Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the
eda ; Wu, Jiaxin
> ; Fu, Siyuan
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function
>
> Jiewen,
> Thanks for the reminder. But TPM didn't have the inc file as NetWorkPkg to set
> the pcd for all platform. The change for TPM1.2 should be at pla
Hi, Zhichao
We should never move/delete a member field of a previous defined protocol
Interface. Instead, these protocol APIs shall be kept and return an error code
If the function is retired. Otherwise the consumer driver may call into an
Incorrect function if it's build with different codebase/P
; From: Yao, Jiewen
> Sent: Friday, March 27, 2020 10:01 AM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Wang, Jian J ; Lu, XiaoyuX
> ; Maciej Rabeda ;
> Wu, Jiaxin ; Fu, Siyuan
> Subject: RE: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate
> function
>
> Goo
age-
> From: devel@edk2.groups.io On Behalf Of Yao, Jiewen
> Sent: Friday, March 27, 2020 10:01 AM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Maciej Rabeda ; Wu, Jiaxin
> ; Fu, Siyuan
> Subject: Re: [edk2-devel] [PATCH 0/8] CryptoPkg: Retir
j Rabeda ; Wu, Jiaxin
> ; Fu, Siyuan
> Subject: [edk2-devel] [PATCH 0/8] CryptoPkg: Retire the deprecate function
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
>
> MD4, AR4, Tdes, Aes Ecb mode, MD5 and
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1682
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
MD4, AR4, Tdes, Aes Ecb mode, MD5 and SHA1 is not secure any longer.
They are all deprecated. Edk2 would not support them any longer.
So remove them.
But uefi spec want to keep MD5 and
24 matches
Mail list logo
