Re: [edk2-devel] [PATCH 0/5] CryptoPkg: Add HMAC-SHA384 cipher support.

2022-09-22 Thread Qi Zhang
Hi, Jiewen Thanks for review. I've sent out v2 patch set for HMAC-SHA384, Hkdf SHA384, AeadAesGcm with comments addressed. All the change is on PR https://github.com/tianocore/edk2/pull/3224. The merge order shall be HMAC-SHA384 -> Hkdf SHA384 -> AeadAesGcm. Thank you! Qi Zhang -Origina

Re: [edk2-devel] [PATCH 0/5] CryptoPkg: Add HMAC-SHA384 cipher support.

2022-09-20 Thread Yao, Jiewen
Thanks for the patch. Please 1) Update the EDKII_CRYPTO_VERSION to higher version 2) Update always append new API to the end of _EDKII_CRYPTO_PROTOCOL (don't insert in the middle) With that change, reviewed-by: Jiewen Yao > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, August

[edk2-devel] [PATCH 0/5] CryptoPkg: Add HMAC-SHA384 cipher support.

2022-08-23 Thread Qi Zhang
HmacSha256 is already supported on Edk2. This patchset is to add HmacSha384 support. With this change, the size increase of BaseCyrptLib is about 7K bytes. HmacSha384 function is verifed by the Host UnitTest. And also it has been integratd in https://github.com/tianocore/edk2-staging/tree/DeviceSe