Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-12-11 Thread Chang, Abner via groups.io
r 28, 2022 11:41 PM > To: Ard Biesheuvel ; devel@edk2.groups.io; Kinney, > Michael D > Cc: Chang, Abner ; Ni, Ray ; > Gao, Liming > Subject: RE: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section > 5.4.2.2 STATIC > > Caution: This message originated from an Externa

Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-11-28 Thread Michael D Kinney
Monday, November 28, 2022 1:08 AM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Chang, Abner ; Ni, Ray ; Gao, > Liming > Subject: Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section > 5.4.2.2 STATIC > > On Tue, 22 Nov 2022 at 19:10, Michael D Kinney >

Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-11-28 Thread Ard Biesheuvel
On Tue, 22 Nov 2022 at 19:10, Michael D Kinney wrote: > > Hi Abner, > > Removing that section 5.4.2.2 is required to close this bug. > > Meaning of 'static' is covered by the ANSI C standards. > > Use of 'static' for non-public variable/functions in EDK II > libraries/modules is recommended. > > H

Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-11-25 Thread Chang, Abner via groups.io
ll functions and global variables that are not > > > referenced outside the current C file." > > > > > > Do you want to capture that in the EDKII C Coding Standard? > > > > > > Thanks, > > > Ray > > > > > > > -Original Me

Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-11-22 Thread Michael D Kinney
; Kinney, Michael D Cc: Chang, Abner ; Ni, Ray ; Gao, Liming Subject: Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC On Tue, Nov 22, 2022 at 6:10 PM Michael D Kinney mailto:michael.d.kin...@intel.com>> wrote: Hi Abner, Removing that section 5.4.2.2 is re

Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-11-22 Thread Pedro Falcato
On Tue, Nov 22, 2022 at 6:10 PM Michael D Kinney wrote: > Hi Abner, > > Removing that section 5.4.2.2 is required to close this bug. > > Meaning of 'static' is covered by the ANSI C standards. > Mike, Sorry for spinning off a bit, but if we're dropping STATIC, can we also drop the other defines

Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-11-22 Thread Michael D Kinney
1:48 PM > > To: devel@edk2.groups.io; Chang, Abner > > Cc: Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section > > 5.4.2.2 STATIC > > > > Caution: This message originated from an External Source. Use proper > > cau

Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-11-21 Thread Chang, Abner via groups.io
iming Gao, is that correct? Abner > -Original Message- > From: Ni, Ray > Sent: Tuesday, November 22, 2022 1:48 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section > 5.4.2.2 STA

Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-11-21 Thread Ni, Ray
Michael D > > Subject: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section > 5.4.2.2 STATIC > > From: Abner Chang > > BZ #1766 > > Remove the entire 5.4.2.2 section. > We are not allowed to use upper-case STATIC in the source file now. > Just fol

[edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-11-21 Thread Chang, Abner via groups.io
From: Abner Chang BZ #1766 Remove the entire 5.4.2.2 section. We are not allowed to use upper-case STATIC in the source file now. Just follow C standard and use the lower-case 'static'. Leave the macro "#deifne STATIC static" there without removing it to keep the backward compatable. Signed-of