r 28, 2022 11:41 PM
> To: Ard Biesheuvel ; devel@edk2.groups.io; Kinney,
> Michael D
> Cc: Chang, Abner ; Ni, Ray ;
> Gao, Liming
> Subject: RE: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section
> 5.4.2.2 STATIC
>
> Caution: This message originated from an Externa
Monday, November 28, 2022 1:08 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: Chang, Abner ; Ni, Ray ; Gao,
> Liming
> Subject: Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section
> 5.4.2.2 STATIC
>
> On Tue, 22 Nov 2022 at 19:10, Michael D Kinney
>
On Tue, 22 Nov 2022 at 19:10, Michael D Kinney
wrote:
>
> Hi Abner,
>
> Removing that section 5.4.2.2 is required to close this bug.
>
> Meaning of 'static' is covered by the ANSI C standards.
>
> Use of 'static' for non-public variable/functions in EDK II
> libraries/modules is recommended.
>
> H
ll functions and global variables that are not
> > > referenced outside the current C file."
> > >
> > > Do you want to capture that in the EDKII C Coding Standard?
> > >
> > > Thanks,
> > > Ray
> > >
> > > > -Original Me
; Kinney, Michael D
Cc: Chang, Abner ; Ni, Ray ; Gao, Liming
Subject: Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section
5.4.2.2 STATIC
On Tue, Nov 22, 2022 at 6:10 PM Michael D Kinney
mailto:michael.d.kin...@intel.com>> wrote:
Hi Abner,
Removing that section 5.4.2.2 is re
On Tue, Nov 22, 2022 at 6:10 PM Michael D Kinney
wrote:
> Hi Abner,
>
> Removing that section 5.4.2.2 is required to close this bug.
>
> Meaning of 'static' is covered by the ANSI C standards.
>
Mike,
Sorry for spinning off a bit, but if we're dropping STATIC, can we also
drop the other defines
1:48 PM
> > To: devel@edk2.groups.io; Chang, Abner
> > Cc: Kinney, Michael D
> > Subject: RE: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section
> > 5.4.2.2 STATIC
> >
> > Caution: This message originated from an External Source. Use proper
> > cau
iming Gao, is that correct?
Abner
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, November 22, 2022 1:48 PM
> To: devel@edk2.groups.io; Chang, Abner
> Cc: Kinney, Michael D
> Subject: RE: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section
> 5.4.2.2 STA
Michael D
>
> Subject: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section
> 5.4.2.2 STATIC
>
> From: Abner Chang
>
> BZ #1766
>
> Remove the entire 5.4.2.2 section.
> We are not allowed to use upper-case STATIC in the source file now.
> Just fol
From: Abner Chang
BZ #1766
Remove the entire 5.4.2.2 section.
We are not allowed to use upper-case STATIC in the source file now.
Just follow C standard and use the lower-case 'static'.
Leave the macro "#deifne STATIC static" there without removing
it to keep the backward compatable.
Signed-of
10 matches
Mail list logo