On Thu, May 16, 2024 at 10:54 AM, WangYang wrote:
Hi,
>
> Hi,Ray
>
> Thank you very much for your attention.
>
The reviewer Ray told you that you patch has some small problems,
For example, the clause "if ((Bus == 1) || (Bus == 2) || (Bus == 3) || (Bus ==
4)) " is useless.
As both code path
ot;
, "Leif Lindholm" , "Kinney,
Michael D"
主题: Re: [edk2-devel] [PATCH] XiangshanSeriesPkg:Add Support for Xilinx RC(PCIE)
Driver
The patch is too big. Can you split it to multiple smaller patches?
As you said, this patch is indeed a bit big.
1. The patch is too big. Can you split it to multiple smaller patches?
> +STATIC
> +UINT64
> +PciSegmentLibGetConfigBase (
> + IN UINT64 Address
> + )
> +{
> + UINT8 Bus;
> + UINT8 Device;
> + UINT8 Function;
> +
> + EXTRACT_PCIE_ADDRESS (Address, Bus, Device, Function);
> + if ((B
,
Yang Wang
> -原始邮件-
> 发件人: WangYang
> 发送时间: 2024-04-17 15:08:06 (星期三)
> 收件人: suni...@ventanamicro.com, g...@danielschaefer.me, devel@edk2.groups.io
> 抄送: "Yang Wang" , "Ran Wang" , "Leif
> Lindholm" , "Michael D Kinney"
>
1.Xilinx RC is XDMA
2.Support NVME storage
Nvme storage needs to be formatted to FAT32 format.
Reviewed-by: Ran Wang
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Sunil V L
Cc: Daniel Schaefer
Signed-off-by: Yang Wang
---
.../XiangshanSeriesPkg/NanhuDev/NanhuDev.dsc | 30 +-
.../XiangshanS
