Re: [edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-24 Thread Rebecca Cran
I don't think I got around to explicitly requiring C11 with -std=c11, but since we use _Static_assert on compilers that don't have MSC Extensions or are C++ compilers we implicitly require it. It's possible it's implemented via an extension though. -- Rebecca Cran On 8/23/23 18:36, Pedro F

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-24 Thread Rebecca Cran
I'd support that. That would leave us with VS2017, VS2019 and VS2022. -- Rebecca Cran On 8/24/23 09:19, Oliver Smith-Denny wrote: On 8/23/2023 2:41 PM, Rebecca Cran wrote: With Visual Studio 2019 adding C11 and C17 support as first-class features, I think we should be safe nowadays to rely

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-23 Thread Pedro Falcato
On Wed, Aug 23, 2023 at 10:41 PM Rebecca Cran wrote: > > With Visual Studio 2019 adding C11 and C17 support as first-class > features, I think we should be safe nowadays to rely on them. But we > should check if older versions that we still support (VS 2015 etc.) > support them too. > > https://de

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-23 Thread Rebecca Cran
devel@edk2.groups.io" ,"ehao...@noos.fr" ,"Yao, Jiewen" Envoyé: lundi 21 Août 2023 16:35 Objet : RE: [edk2-devel] [PATCH] Use C99 flexible arrays Hi This fix breaks the compatibility. Have you tested all features that depends on this data structure? Thank you Yao, Jiewen &g

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-22 Thread Andrew Fish via groups.io
t;ehao...@noos.fr" ,"Yao, Jiewen" > Envoyé: lundi 21 Août 2023 16:35 > Objet : RE: [edk2-devel] [PATCH] Use C99 flexible arrays > > Hi > This fix breaks the compatibility. > > Have you tested all features that depends on this data structure? > > Thank yo

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-21 Thread ehaouas
‌ Hi, No, I didn't.   De : "Yao, Jiewen" A : "devel@edk2.groups.io" ,"ehao...@noos.fr" ,"Yao, Jiewen" Envoyé: lundi 21 Août 2023 16:35 Objet : RE: [edk2-devel] [PATCH] Use C99 flexible arrays   Hi This fix breaks the compatibility. Have you tested all

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-21 Thread Yao, Jiewen
> Cc: Elyes Haouas > Subject: [edk2-devel] [PATCH] Use C99 flexible arrays > > Use C99 flexible arrays instead of older style of one-element or > zero-length arrays. > It allows the compiler to generate errors when the flexible array does > not occur at the end in the structure.

[edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-20 Thread Elyes Haouas
Use C99 flexible arrays instead of older style of one-element or zero-length arrays. It allows the compiler to generate errors when the flexible array does not occur at the end in the structure. Signed-off-by: Elyes Haouas --- EmbeddedPkg/Include/fdt.h | 4 ++-- ...