Hi Guomin,
Could you please point me to the proposed change?
Thanks,
Kun
From: Jiang, Guomin
Sent: Wednesday, April 8, 2020 6:30 PM
To: Sean Brogan ; devel@edk2.groups.io
Cc: Kun Qin
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib:
Correct dereferred pointer
...@microsoft.com>>
Sent: Friday, April 10, 2020 3:18 PM
To: Jiang, Guomin mailto:guomin.ji...@intel.com>>; Sean
Brogan mailto:sean.bro...@microsoft.com>>;
devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Cor
2.groups.io>
Cc: Kun Qin mailto:kun@microsoft.com>>
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib:
Correct dereferred pointer.
Hi Sean,
I think it meet the original code logic more closely.
According to the LoadUnitTestCache(), it need pointer t
suggested change and think both are the same logic.
Hi Qin,
Can you give some comment?
Best Regards
guomin
From: sean.brogan via []
Sent: Wednesday, April 8, 2020 2:00 PM
To: Jiang, Guomin ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct
dereferred
Guomin,
Can you speak to why you implemented differently than the suggested and
validated patch? Seems you created a local whereas ours just used the internal
data member.
Thanks
sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#57
> ; Bret Barkelew
>
> Subject: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct
> dereferred pointer.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2609
>
> The copied pointer (SavedState) will be updated by LoadUnitTestCache
> call. But the change
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2609
The copied pointer (SavedState) will be updated by LoadUnitTestCache
call. But the change of SavedState will not update source pointer, which
is NewFramework->SavedState in this case.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
