Reviewed-by Sean Rhodes
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87912): https://edk2.groups.io/g/devel/message/87912
Mute This Topic: https://groups.io/mt/89710183/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https:/
As a package reviewer, you just need review it and reply it with “Reviewed-by”
then the maintainer would merge it.
Thanks,
Guo
From: Sean Rhodes
Sent: Monday, March 21, 2022 1:52 AM
To: Dong, Guo ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error
The
The patch looks good to me, and it has been confirmed by several others from
the coreboot community. However, I don't have the capability to merge.
Thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#8): https://edk2.groups.io
: Dong, Guo ; Ma, Maurice ; You,
Benjamin
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error
I don't understand the need of "+ DEFINE PLATFORMX64_ENABLE = TRUE".
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sean Rhodes
Sent: Friday, March 1
2-devel] [PATCH] UefiPayloadPkg: Fix build error
From: Guo Dong
On windows build, need add -DPLATFORMX64_ENABLE=TRUE in the build
command line beside -DNETWORK_DRIVER_ENABLE=TRUE in order build
network features. So set PLATFORMX64_ENABLE to TRUE when need build
network feature.
On Linux build,
From: Guo Dong
On windows build, need add -DPLATFORMX64_ENABLE=TRUE in the build
command line beside -DNETWORK_DRIVER_ENABLE=TRUE in order build
network features. So set PLATFORMX64_ENABLE to TRUE when need build
network feature.
On Linux build, DSC file should not have PcdAllowHttpConnections
wh
From: Guo Dong
On windows build, need add "-DPLATFORMX64_ENABLE=TRUE" in the build
command line beside -DNETWORK_DRIVER_ENABLE=TRUE in order build
network features. So update DSC to set PLATFORMX64_ENABLE to TRUE
when building network feature.
On Linux build, DSC file should not have PcdAllowHttp
