Hi Ray,
Could you help to review this?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89814): https://edk2.groups.io/g/devel/message/89814
Mute This Topic: https://groups.io/mt/88756033/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubs
Hey Benjamin
The commit has been around for a while now and is perfectly functional. Why
don't we upstream it and then `FindCbTag()` and `CopyMem()` can be a follow-up
patch when/if time allows?
Cheers
Sean
Squashing that commit in:
[PATCH] UefiPayloadPkg: Add support for logging to CBMEM cons
From: Benjamin Doron
Tested on QEMU, dumping the appropriate memory region in UEFI shell
shows the TianoCore log. `find_cb_subtable` is sourced from STM/SeaBIOS.
Signed-off-by: Benjamin Doron
---
UefiPayloadPkg/Include/Coreboot.h | 14 +
.../Library/CbSerialPortLib/CbSerialPortLib
Hi,
Thanks for looking at my patch.
I probably need to refine the library before it's ready to be upstreamed.
Two items on my list were finally debugging how to make `FindCbTag()` work,
and using `CopyMem()` instead of byte-assignment.
This commit is missing my follow-up: We must not define MDEPK
