Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-17 Thread Zeng, Star
r...@redhat.com > > > > Cc: Dong, Eric ; Ni, Ray ; > > > > Kumar, Chandana C ; Zeng, Star > > > > > > > > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: > > > > Remove CPU generation check > > &

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-17 Thread Ni, Ray
019 11:05 AM > To: Ni, Ray ; devel@edk2.groups.io; ler...@redhat.com > Cc: Dong, Eric ; Kumar, Chandana C > ; Li, Kevin Y ; Zeng, > Star > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: > Remove CPU generation check > > Situation: All the generations (i

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-17 Thread Laszlo Ersek
>> -Original Message- >> From: Ni, Ray >> Sent: Friday, May 17, 2019 9:04 AM >> To: Zeng, Star ; devel@edk2.groups.io; >> ler...@redhat.com >> Cc: Dong, Eric ; Kumar, Chandana C >> >> Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonF

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Zeng, Star
y > Sent: Friday, May 17, 2019 9:04 AM > To: Zeng, Star ; devel@edk2.groups.io; > ler...@redhat.com > Cc: Dong, Eric ; Kumar, Chandana C > > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: > Remove CPU generation check > > Star, > I think the

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Ni, Ray
Cc: Dong, Eric ; Ni, Ray ; Kumar, > Chandana C ; Zeng, Star > > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: > Remove CPU generation check > > Laszlo, > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.g

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Dong, Eric
> > To: Zeng, Star ; devel@edk2.groups.io > > Cc: Dong, Eric ; Ni, Ray ; > > Kumar, Chandana C > > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: > > Remove CPU generation check > > > > Hi Star, > > > > On 05/16/19 12

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Zeng, Star
Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: > Remove CPU generation check > > Hi Star, > > On 05/16/19 12:33, Star Zeng wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1679 > > > > The checking to CpuInfo->CpuIdVersionInfoEcx.Bits.AESNI is

Re: [edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Laszlo Ersek
Hi Star, On 05/16/19 12:33, Star Zeng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1679 > > The checking to CpuInfo->CpuIdVersionInfoEcx.Bits.AESNI is enough, > the checking to CPU generation could be removed, then the code > could be reused by more platforms. > > Cc: Laszlo Ersek

[edk2-devel] [PATCH] UefiCpuPkg CpuCommonFeaturesLib: Remove CPU generation check

2019-05-16 Thread Zeng, Star
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1679 The checking to CpuInfo->CpuIdVersionInfoEcx.Bits.AESNI is enough, the checking to CPU generation could be removed, then the code could be reused by more platforms. Cc: Laszlo Ersek Cc: Eric Dong Cc: Ruiyu Ni Cc: Chandana Kumar Signed-of