Re: [edk2-devel] [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector

2020-06-22 Thread Dong, Eric
Reviewed-by: Eric Dong eric.d...@intel.com Pushed: SHA-1: 00b8bf7eda00fb6f0197d3968b6078cfdb4870fa * UefiCpuPkg/SecCore: Add pre-memory AP vector REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2776 Thanks, Eric From: Ni, Ray Sent: Tuesday, June 23, 2020 8:57 AM

Re: [edk2-devel] [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector

2020-06-22 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Cole, Deric > Sent: Wednesday, June 3, 2020 12:42 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek > Subject: RE: [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector > > Ray, > > The NOP is not a functional chan

Re: [edk2-devel] [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector

2020-06-02 Thread Cole, Deric
Ray, The NOP is not a functional change, it's just for ease of debug. Before, this file was padding with zeros in various places. When viewing this memory using a disassembler, two subsequent zero-bytes show up as an ADD instruction, which I found confusing. But worse, if the number of zero-byt

Re: [edk2-devel] [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector

2020-06-02 Thread Laszlo Ersek
On 06/02/20 00:32, Deric Cole wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2776 > > Add a vector at 0xFF000 (0xF000) that can be used by Init-SIPI-SIPI > to start an AP before memory is initialized. This vector jumps into the > same SEC entry point as the ordinary reset vector,

[edk2-devel] [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector

2020-06-02 Thread Deric Cole
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2776 Add a vector at 0xFF000 (0xF000) that can be used by Init-SIPI-SIPI to start an AP before memory is initialized. This vector jumps into the same SEC entry point as the ordinary reset vector, with a special value of "AP" in the DI register

Re: [edk2-devel] [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector

2020-06-01 Thread Ni, Ray
Deric, Can you explain why changing all padding 0x0 to 0x90 (nop) in your patch? Is it required to enable AP start up in pre-mem? Thanks, Ray > -Original Message- > From: Cole, Deric > Sent: Tuesday, June 2, 2020 6:32 AM > To: devel@edk2.groups.io > Cc: Cole, Deric ; Dong, Eric ; Ni, >