Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors

2021-02-17 Thread Nickle Wang
Hi Abner, You many want to update the function description. It mentioned "UTF8 encoded string" but the input string type is CHAR8, not CHAR16. Thanks, Nickle > -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Monday, January 25, 2021 12:32 PM > To: devel@edk2.gr

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors

2021-02-17 Thread Abner Chang
ney > Subject: RE: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors > > Hi Leif, > I split this patch into 3 separate patches. Please ignore the old one. > > Thank > Abner > > > -Original Message- > > From: Chang, Abner (HPS SW/FW Technologist

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors

2021-02-07 Thread Abner Chang
> -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Thursday, January 28, 2021 10:31 PM > To: Leif Lindholm > Cc: devel@edk2.groups.io; Wang, Nickle (HPS SW) ; > Michael D Kinney > Subject: RE: [edk2-devel] [PATCH] RedfishPkg/Json

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors

2021-01-28 Thread Abner Chang
) ; > Michael D Kinney > Subject: RE: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors > > > > > -Original Message- > > From: Leif Lindholm [mailto:l...@nuviainc.com] > > Sent: Thursday, January 28, 2021 7:17 PM > > To: Chang, Abner (HPS S

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors

2021-01-28 Thread Abner Chang
> -Original Message- > From: Leif Lindholm [mailto:l...@nuviainc.com] > Sent: Thursday, January 28, 2021 7:17 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io; Wang, Nickle (HPS SW) ; > Michael D Kinney > Subject: Re: [edk2-devel] [PATC

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors

2021-01-28 Thread Leif Lindholm
On Thu, Jan 28, 2021 at 04:02:54 +, Chang, Abner (HPS SW/FW Technologist) wrote: > > > + # C4706: assignment within conditional expression > > ># > > ># Define macro HAVE_CONFIG_H to include jansson_private_config.h to > > build. > > ># Undefined _WIN32, WIN64, _MSC_VER macros >

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors

2021-01-27 Thread Abner Chang
nney > > Subject: Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors > > Hi Abner, > > On Mon, Jan 25, 2021 at 12:31:54 +0800, Abner Chang wrote: > > This patch fixes the build errors when build JsonLib with EDK2 Redfish > > feature driver. > > > >

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors

2021-01-26 Thread Leif Lindholm
Hi Abner, On Mon, Jan 25, 2021 at 12:31:54 +0800, Abner Chang wrote: > This patch fixes the build errors when build JsonLib with EDK2 > Redfish feature driver. > > - Add JsonLoadString function to load a NULL terminated-string JSON > - json_string_value() in JsonValueGetAsciiString () is removed

[edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors

2021-01-24 Thread Abner Chang
This patch fixes the build errors when build JsonLib with EDK2 Redfish feature driver. - Add JsonLoadString function to load a NULL terminated-string JSON - json_string_value() in JsonValueGetAsciiString () is removed by accident. Signed-off-by: Abner Chang Cc: Leif Lindholm Cc: Nickle Wang C