Hi Abner,
You many want to update the function description. It mentioned "UTF8 encoded
string" but the input string type is CHAR8, not CHAR16.
Thanks,
Nickle
> -Original Message-
> From: Chang, Abner (HPS SW/FW Technologist)
> Sent: Monday, January 25, 2021 12:32 PM
> To: devel@edk2.gr
ney
> Subject: RE: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors
>
> Hi Leif,
> I split this patch into 3 separate patches. Please ignore the old one.
>
> Thank
> Abner
>
> > -Original Message-
> > From: Chang, Abner (HPS SW/FW Technologist
> -Original Message-
> From: Chang, Abner (HPS SW/FW Technologist)
> Sent: Thursday, January 28, 2021 10:31 PM
> To: Leif Lindholm
> Cc: devel@edk2.groups.io; Wang, Nickle (HPS SW) ;
> Michael D Kinney
> Subject: RE: [edk2-devel] [PATCH] RedfishPkg/Json
) ;
> Michael D Kinney
> Subject: RE: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors
>
>
>
> > -Original Message-
> > From: Leif Lindholm [mailto:l...@nuviainc.com]
> > Sent: Thursday, January 28, 2021 7:17 PM
> > To: Chang, Abner (HPS S
> -Original Message-
> From: Leif Lindholm [mailto:l...@nuviainc.com]
> Sent: Thursday, January 28, 2021 7:17 PM
> To: Chang, Abner (HPS SW/FW Technologist)
> Cc: devel@edk2.groups.io; Wang, Nickle (HPS SW) ;
> Michael D Kinney
> Subject: Re: [edk2-devel] [PATC
On Thu, Jan 28, 2021 at 04:02:54 +, Chang, Abner (HPS SW/FW Technologist)
wrote:
> > > + # C4706: assignment within conditional expression
> > >#
> > ># Define macro HAVE_CONFIG_H to include jansson_private_config.h to
> > build.
> > ># Undefined _WIN32, WIN64, _MSC_VER macros
>
nney
>
> Subject: Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors
>
> Hi Abner,
>
> On Mon, Jan 25, 2021 at 12:31:54 +0800, Abner Chang wrote:
> > This patch fixes the build errors when build JsonLib with EDK2 Redfish
> > feature driver.
> >
> >
Hi Abner,
On Mon, Jan 25, 2021 at 12:31:54 +0800, Abner Chang wrote:
> This patch fixes the build errors when build JsonLib with EDK2
> Redfish feature driver.
>
> - Add JsonLoadString function to load a NULL terminated-string JSON
> - json_string_value() in JsonValueGetAsciiString () is removed
This patch fixes the build errors when build JsonLib with EDK2
Redfish feature driver.
- Add JsonLoadString function to load a NULL terminated-string JSON
- json_string_value() in JsonValueGetAsciiString () is removed
by accident.
Signed-off-by: Abner Chang
Cc: Leif Lindholm
Cc: Nickle Wang
C