Re: [edk2-devel] [PATCH] MdePkg: Code optimization to SMM InternalAllocateAlignedPages

2023-05-18 Thread duntan
Ray, Thanks for the comments. I'll refine the commit message according to your suggestions in V2 version patch. Thanks, Dun -Original Message- From: Ni, Ray Sent: Thursday, May 18, 2023 2:59 PM To: Tan, Dun ; devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Su

Re: [edk2-devel] [PATCH] MdePkg: Code optimization to SMM InternalAllocateAlignedPages

2023-05-17 Thread Ni, Ray
Dun, I can understand what you are trying to describe in the commit message. I have some suggestions/questions that might help you refine the commit message a bit better. Code changes look good to me. Thanks, Ray > -Original Message- > From: Tan, Dun > Sent: Thursday, May 18, 2023 2:37

[edk2-devel] [PATCH] MdePkg: Code optimization to SMM InternalAllocateAlignedPages

2023-05-17 Thread duntan
This commit is code optimization to InternalAllocateAlignedPages of SmmMemoryAllocationLib which can reduce free memory fragments. Also it can reduce one pre-allocation page. Let's take a simple example: The expected pages size is 8KB, Alignment value is 8KB. In original InternalAllocateAlignedPa