Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-06-06 Thread Wu, Hao A
; devel@edk2.groups.io; Hsueh, > Hong-Chih (Neo) > Cc: Chang, Abner > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in > AhciPei PEIM > > Thanks. > Reviewed-by: Hao A Wu > > Best Regards, > Hao Wu > > > -Original Message-

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-06-06 Thread Chang, Abner via groups.io
ael D ; Gao, Liming ; devel@edk2.groups.io; Hsueh, Hong-Chih (Neo) ; Chang, Abner ; He, Jiangang Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper ca

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-06-05 Thread Wu, Hao A
, 2023 12:32 PM To: Hsueh, Hong-Chih (Neo) ; Chang, Abner ; He, Jiangang ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thanks all, Tried to merge the patch via PR - https://github.com/tianocore/edk2/pull/4478, but failed 3 times

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-06-04 Thread Wu, Hao A
, Jiangang ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM [AMD Official Use Only - General] Hi Abner, Thank you for your feedback. I updated the commit and re-create the PR as below: https://github.com/tianocore/edk2/pull/4471

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-06-02 Thread Hsueh, Hong-Chih (Neo) via groups.io
(Neo) ; Wu, Hao A ; He, Jiangang ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM [AMD Official Use Only - General] Hi Leo, Please add Hao’s RB in the commit message below your signed-off-by, thus we know this patch has been

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-06-02 Thread Hsueh, Hong-Chih (Neo) via groups.io
, June 1, 2023 10:14 PM To: He, Jiangang ; devel@edk2.groups.io ; Hsueh, Hong-Chih (Neo) Cc: Chang, Abner Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM [AMD Official Use Only - General] Caution: This message originated from an External Source. Use

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-06-02 Thread Chang, Abner via groups.io
.hs...@amd.com>> Cc: Chang, Abner mailto:abner.ch...@amd.com>> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper caution when opening attachments

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-06-01 Thread Wu, Hao A
nal Message- > From: Wu, Hao A > Sent: Tuesday, May 30, 2023 10:30 PM > To: devel@edk2.groups.io; Hsueh, Hong-Chih (Neo) chih.hs...@amd.com> > Cc: He, Jiangang ; Chang, Abner > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in > AhciPei PEI

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-05-31 Thread He, Jiangang via groups.io
; Hsueh, Hong-Chih (Neo) Cc: He, Jiangang ; Chang, Abner Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Thanks, the code

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-05-30 Thread Wu, Hao A
.groups.io > Cc: jiangang...@amd.com; abner.ch...@amd.com; Neo Hsueh chih.hs...@amd.com> > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in > AhciPei PEIM > > If there is no port multiplier, PortMultiplierPort should be converted > to 0 to follow AHCI spec.

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-05-23 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Neo, I don't see you add the maintainers either in commit message or email CC list. I added them. To this patch, Acked-by: Abner Chang Thanks Abner > -Original Message- > From: Hsueh, Hong-Chih (Neo) > Sent: Wednesday, May 24, 2023 1:07 AM > To:

[edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM

2023-05-23 Thread Neo Hsueh via groups.io
If there is no port multiplier, PortMultiplierPort should be converted to 0 to follow AHCI spec. The same logic already applied in AtaAtapiPassThruDxe driver. Signed-off-by: Neo Hsueh --- MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++ 1 file changed, 10 insertions(+) diff --git