Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-15 Thread Ashish Singhal
mechanism for that. Thanks Ashish From: Wu, Hao A Sent: Monday, October 14, 2019 7:21 PM To: Ashish Singhal ; devel@edk2.groups.io ; Ni, Ray Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation Hello, Sorry for the delayed

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-14 Thread Wu, Hao A
future. Best Regards, Hao Wu From: Ashish Singhal [mailto:ashishsin...@nvidia.com] Sent: Tuesday, October 15, 2019 2:17 AM To: Wu, Hao A; devel@edk2.groups.io; Ni, Ray Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation Hello Hao, Were you able to validate t

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-14 Thread Ashish Singhal
Page Allocation Patch set 2 has been submitted for review. Thanks Ashish From: Wu, Hao A Sent: Thursday, October 10, 2019 11:53 PM To: devel@edk2.groups.io ; Ashish Singhal ; Ni, Ray Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-11 Thread Ashish Singhal
Patch set 2 has been submitted for review. Thanks Ashish From: Wu, Hao A Sent: Thursday, October 10, 2019 11:53 PM To: devel@edk2.groups.io ; Ashish Singhal ; Ni, Ray Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation Hello

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-10 Thread Wu, Hao A
Wu, Hao A Sent: Thursday, October 10, 2019 9:00 PM To: devel@edk2.groups.io; Ashish Singhal ; Ni, Ray Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation Thanks Ashish, Please help to send out the fix for XhciPei in a separate patch as well. I can help to see if ver

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-10 Thread Ashish Singhal
: devel@edk2.groups.io; Ashish Singhal ; Ni, Ray Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation Thanks Ashish, Please help to send out the fix for XhciPei in a separate patch as well. I can help to see if verification can be done on my side. Best Regards, Hao Wu

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-10 Thread Wu, Hao A
: Wu, Hao A; devel@edk2.groups.io; Ni, Ray Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation Hello Hao, I agree that for completeness we should fix the issue in both DXE as well as PEI but on my target, we do not have any PEI phase for me to be able to verify

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-10 Thread Ashish Singhal
Hello Hao, I agree that for completeness we should fix the issue in both DXE as well as PEI but on my target, we do not have any PEI phase for me to be able to verify any change that I will be making. If you still want, I can still make the change so that someone else can verify or we can have

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-09 Thread Wu, Hao A
> -Original Message- > From: Ashish Singhal [mailto:ashishsin...@nvidia.com] > Sent: Thursday, October 10, 2019 9:58 AM > To: Wu, Hao A; devel@edk2.groups.io; Ni, Ray > Subject: RE: [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation > > Hello Hao, > > I can see that the PEI also ha

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-09 Thread Ashish Singhal
Hello Hao, I can see that the PEI also has the same issue and take a look at that as well but I have no way to verify that as we are not using it. For the change I have made in DXE, I have verified it with an alignment of 4K and 64K. Thanks Ashish -Original Message- From: Wu, Hao A S

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-09 Thread Wu, Hao A
> -Original Message- > From: Ashish Singhal [mailto:ashishsin...@nvidia.com] > Sent: Thursday, October 10, 2019 1:02 AM > To: devel@edk2.groups.io; Wu, Hao A; Ni, Ray > Cc: Ashish Singhal > Subject: [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation > > While allocating pages aligne

[edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-09 Thread Ashish Singhal
While allocating pages aligned at an alignment higher than 4K, allocate memory taking into consideration the padding required for that alignment. The calls to free pages takes care of this already. Signed-off-by: Ashish Singhal --- MdeModulePkg/Bus/Pci/XhciDxe/UsbHcMem.c | 2 +- 1 file changed,