On 11/6/23 01:59, gaoliming wrote:
> Laszlo：
> I agree your suggestion. We can submit a new request to update oniguruma to
> the latest version.
>
> This patch avoids the warning on the current version. I think this change
> is OK. I would like to merge this fix first.
OK.
Filed this BZ:
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Nhi Pham
> 发送时间: 2023年11月5日 15:09
> 收件人: devel@edk2.groups.io; j...@nvidia.com
> 抄送: jian.j.w...@intel.com; gaolim...@byosoft.com.cn
> 主题: Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix
> clang error
>
>
io 代表 Laszlo Ersek
> 发送时间: 2023年11月5日 19:33
> 收件人: devel@edk2.groups.io; j...@nvidia.com
> 抄送: jian.j.w...@intel.com; gaolim...@byosoft.com.cn
> 主题: Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix
> clang error
>
> On 10/3/23 17:04, Jake Garver via groups.io
On 10/3/23 17:04, Jake Garver via groups.io wrote:
> Ignore old style declaration warnings in oniguruma/src/st.c. This was
> already ignored for MSFT, but newer versions of clang complain as well.
>
> Signed-off-by: Jake Garver
> ---
> .../Universal/RegularExpressionDxe/RegularExpressionDxe.inf
Hi Liming,
Could you please help review and get this patch merged within the next
edk2-stable tag?
Thanks,
Nhi
On 10/23/2023 11:27 AM, Nhi Pham via groups.io wrote:
> This looks good to me. I also build-tested this patch.
>
> Reviewed-by: Nhi Pham
> Tested-by: Nhi Pham
>
> On 10/3/2023 10:04
This looks good to me. I also build-tested this patch.
Reviewed-by: Nhi Pham
Tested-by: Nhi Pham
On 10/3/2023 10:04 PM, Jake Garver via groups.io wrote:
Ignore old style declaration warnings in oniguruma/src/st.c. This was
already ignored for MSFT, but newer versions of clang complain as wel
Ignore old style declaration warnings in oniguruma/src/st.c. This was
already ignored for MSFT, but newer versions of clang complain as well.
Signed-off-by: Jake Garver
---
.../Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 1 +
1 file changed, 1 insertion(+)
diff --git
a/MdeM
