Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string

2020-10-06 Thread Laszlo Ersek
On 10/05/20 23:27, Jeff Brasen wrote: > Are we looking for any other reviews on this? I don't think so; Dandan is a designated reviewer for "MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c". The MdeModulePkg maintainers should merge this patch. (Dandan seems to have no "M" access anywhere i

Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string

2020-10-05 Thread Jeff Brasen
Are we looking for any other reviews on this? Thanks, Jeff From: Jeff Brasen Sent: Tuesday, September 22, 2020 4:13 PM To: Bi, Dandan ; devel@edk2.groups.io Cc: Dong, Eric Subject: Re: [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string Thanks Dandan, are we waiting for any additiona

Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string

2020-09-22 Thread Jeff Brasen
Thanks Dandan, are we waiting for any additional reviews on this change? Thanks, Jeff From: Bi, Dandan Sent: Monday, September 14, 2020 8:15 AM To: Jeff Brasen ; devel@edk2.groups.io Cc: Dong, Eric Subject: RE: [PATCH] MdeModulePkg/HiiDatabase: Do not modify

Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string

2020-09-14 Thread Dandan Bi
Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: Jeff Brasen > Sent: Saturday, September 12, 2020 1:09 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric ; > Jeff Brasen > Subject: [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string > > Update funct

[edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string

2020-09-11 Thread Jeff Brasen
Update function behavior to not modify the incoming string that is marked as CONST in the prototype. Signed-off-by: Jeff Brasen --- .../Universal/HiiDatabaseDxe/ConfigRouting.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Universal/HiiData

Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string

2020-03-24 Thread Dandan Bi
ic ; > Jeff Brasen > Subject: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify > CONST string > > Update function behavior to not modify the incoming string that is marked as > CONST in the prototype. > > Signed-off-by: Jeff Brasen > --- > .../Univ

[edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string

2020-03-19 Thread Jeff Brasen
Update function behavior to not modify the incoming string that is marked as CONST in the prototype. Signed-off-by: Jeff Brasen --- .../Universal/HiiDatabaseDxe/ConfigRouting.c| 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Universal/HiiData