On 10/05/20 23:27, Jeff Brasen wrote:
> Are we looking for any other reviews on this?
I don't think so; Dandan is a designated reviewer for
"MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c".
The MdeModulePkg maintainers should merge this patch. (Dandan seems to
have no "M" access anywhere i
Are we looking for any other reviews on this?
Thanks,
Jeff
From: Jeff Brasen
Sent: Tuesday, September 22, 2020 4:13 PM
To: Bi, Dandan ; devel@edk2.groups.io
Cc: Dong, Eric
Subject: Re: [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string
Thanks Dandan, are we waiting for any additiona
Thanks Dandan, are we waiting for any additional reviews on this change?
Thanks,
Jeff
From: Bi, Dandan
Sent: Monday, September 14, 2020 8:15 AM
To: Jeff Brasen ; devel@edk2.groups.io
Cc: Dong, Eric
Subject: RE: [PATCH] MdeModulePkg/HiiDatabase: Do not modify
Reviewed-by: Dandan Bi
Thanks,
Dandan
> -Original Message-
> From: Jeff Brasen
> Sent: Saturday, September 12, 2020 1:09 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Dong, Eric ;
> Jeff Brasen
> Subject: [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string
>
> Update funct
Update function behavior to not modify the incoming string that is
marked as CONST in the prototype.
Signed-off-by: Jeff Brasen
---
.../Universal/HiiDatabaseDxe/ConfigRouting.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/MdeModulePkg/Universal/HiiData
ic ;
> Jeff Brasen
> Subject: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify
> CONST string
>
> Update function behavior to not modify the incoming string that is marked as
> CONST in the prototype.
>
> Signed-off-by: Jeff Brasen
> ---
> .../Univ
Update function behavior to not modify the incoming string that is
marked as CONST in the prototype.
Signed-off-by: Jeff Brasen
---
.../Universal/HiiDatabaseDxe/ConfigRouting.c| 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/MdeModulePkg/Universal/HiiData