Hi Ray,
Thanks your input. I will remove this debug message as well.
Best Regards,
Ethan
> -Original Message-
> From: Ni, Ray
> Sent: Friday, November 8, 2019 4:59 PM
> To: Tsao, Ethan ; devel@edk2.groups.io
> Cc: Chaganty, Rangasai V
> Subject: RE: [PATCH] IntelSiliconPkg/Library:Add B
When a API needs enough buffer prepared by caller, there are two styles of APIs:
1. Status FillBuffer (VOID *Buffer, UINTN BufferSize)
BufferSize is passed by value so the API has no way to return back the
required size.
It's ok as long as the caller is able to calculate the proper size
Hi Ray,
There is one debug message print available and requested Config block size
while Config Block table is not enough to add new.
Caller only know size is not enough by return status. With this debug message,
Caller can know how many size need to enlarge.
What do you think to keep this debug
Hi Ray,
I do agree with you. I will remove all debug message since all error scenario
can be cover by return status.
Caller can understanding through return status.
Best Regards,
Ethan
> -Original Message-
> From: Ni, Ray
> Sent: Friday, November 8, 2019 2:25 PM
> To: Tsao, Ethan ; deve
Ethan,
What if all of the debug message are removed?
Library especially very fundamental like ConfigBlock is better to be quite.
It's the ConfigBlock API designer's responsibility to ensure the error is
returned
properly to caller, otherwise it's the API's bug.
When the API can return correct stat
Hi Ray,
Thanks your good input. I just review all debug message and most print is for
error report purpose, such as allocate memory failure,...etc.
>From my opinion, this kind debug message is useful for BIOS when unexpected
>error happen. In normal case, it will not be print.
Best Regards,
Etha
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318
Establish one copy of Config blocks library class and instance
in IntelSiliconPkg and remove copies from other silicon packages
, like KabyLakeSiliconPkg, CoffelakeSiliconPkg.
Signed-off-by: Ethan Tsao
Cc: Sai Chaganty
Cc: Ray Ni
---
Si
