Minor comment inline.
> -Original Message-
> From: Chiu, Chasel
> Sent: Friday, April 12, 2019 11:02 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH] IntelFsp2WrapperPkg: Perform post FSP-S process.
>
> From: "Chasel, Chiu"
>
>
Hi Chasel,
Looks good! This is mildly unrelated to your change, but could you put a
comment on the following line that informs the reader that 1 == API Mode?
if (PcdGet8 (PcdFspModeSelection) == 1) {
Once that is done... Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
From: "Chasel, Chiu"
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1716
In API mode FSP wrapper will perform some post
FSP-S process but such process was skipped in Dispatch
mode which may impact some of boot loaders.
To align behavior between API and Dispatch, an
End-of-Pei callback is in
