Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-13 Thread Du Lin
This patch has been updated to address Ray's comment. For more details, please check [PATCH v2] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit() (groups.io) ( https://edk2.groups.io/g/devel/message/116723 ). Thanks Ray for the comment. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You recei

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-13 Thread Ni, Ray
> - ASSERT (MeasurementExcludedFvPpi != NULL); > + if (MeasurementExcludedFvPpi == NULL) { > +ASSERT (FALSE); I prefer the original meaningful assertion instead of ASSERT (FALSE). Adding if-check is a good change to me. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-12 Thread Ashraf Ali S
Reviewed-by: S, Ashraf Ali Thanks., S, Ashraf Ali -Original Message- From: Lin, Du Sent: Tuesday, March 12, 2024 2:58 PM To: devel@edk2.groups.io Cc: Lin, Du ; S, Ashraf Ali ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Desimone, Nathaniel L ; Zeng, Star ; Mohapatra, Susovan

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-12 Thread Chen, Gang C
Reviewed-by: Chen Gang C BR Gang -Original Message- From: Lin, Du Sent: Tuesday, March 12, 2024 5:28 PM To: devel@edk2.groups.io Cc: Lin, Du ; S, Ashraf Ali ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Desimone, Nathaniel L ; Zeng, Star ; Mohapatra, Susovan ; Kuo, Ted Subje

[edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-12 Thread Du Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4701 The error handling of FspmWrapperInit() is limited to ASSERT statements only, which only works in debug builds, but not in release builds. Fix the issue by enhancing the error handling of FspmWrapperInit() to cover both debug builds and rele