Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix string copy issue

2019-05-21 Thread Liming Gao
2 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Gao, Liming ; Wu, Hao A > Subject: RE: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix > string copy issue > > Can the library in MdeModulePkg be used? > The IntelFrameworkPkg/IntelFrameworkModulePkg will be removed

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix string copy issue

2019-05-21 Thread Ni, Ray
Liming ; Wu, Hao A > Subject: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix > string copy issue > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1826 > > There is a bug to use AsciiStrCpyS to copy a truncated string. If would cause > an assert because the t

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix string copy issue

2019-05-21 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Wu, Hao A > Sent: Tuesday, May 21, 2019 4:03 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Gao, Liming > Subject: RE: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix > string copy issue > &

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix string copy issue

2019-05-21 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Tuesday, May 21, 2019 3:50 PM > To: devel@edk2.groups.io > Cc: Gao, Liming; Wu, Hao A > Subject: [edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugL

[edk2-devel] [PATCH] IntelFrameworkModulePkg/DebugLib: Fix string copy issue

2019-05-21 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1826 There is a bug to use AsciiStrCpyS to copy a truncated string. If would cause an assert because the truncated length is always less than the source string length. It should use the AsciiStrnCpyS instead. Cc: Liming Gao Cc: Hao A Wu Signed