Re: [edk2-devel] [PATCH] Ext4Pkg: Fix CRC16 checksumming on block groups

2023-12-03 Thread Pedro Falcato
On Sun, Dec 3, 2023 at 10:56 PM Marvin Häuser wrote: > > Reviewed-by: Marvin Häuser Thank you! Pushed as b95395b. -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111999): https://edk2.groups.io/g/devel/message/111999 Mute Th

Re: [edk2-devel] [PATCH] Ext4Pkg: Fix CRC16 checksumming on block groups

2023-12-03 Thread Marvin Häuser
Reviewed-by: Marvin Häuser > On Dec 3, 2023, at 23:41, Pedro Falcato wrote: > > Old filesystems (around 2008 and older) do not use CRC32c > but rather CRC16-ANSI. Previously, the CalculateCrc16Ansi function was > broken and gave us wrong checksums. Adapt to the new interface. > > And while we

[edk2-devel] [PATCH] Ext4Pkg: Fix CRC16 checksumming on block groups

2023-12-03 Thread Pedro Falcato
Old filesystems (around 2008 and older) do not use CRC32c but rather CRC16-ANSI. Previously, the CalculateCrc16Ansi function was broken and gave us wrong checksums. Adapt to the new interface. And while we're at it, fix the checksum algorithm itself - the crc16 algorithm just skips over the bg_che