Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiHobLib: Get rid of PeCoffLoaderProtocol

2023-03-13 Thread Leif Lindholm
On Mon, Mar 13, 2023 at 18:20:20 +0100, Ard Biesheuvel wrote: > On Mon, 13 Mar 2023 at 15:50, Leif Lindholm wrote: > > > > No objection as such, but do we know what it was ever used for? > > > > / > > Leif > > > > From edk2-platforms (see below). The reason was probably to avoid > having two

Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiHobLib: Get rid of PeCoffLoaderProtocol

2023-03-13 Thread Ard Biesheuvel
On Mon, 13 Mar 2023 at 15:50, Leif Lindholm wrote: > > No objection as such, but do we know what it was ever used for? > > / > Leif > >From edk2-platforms (see below). The reason was probably to avoid having two copies of that code in the firmware binary. commit b7505f9c27f11064373ce3359ec

Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiHobLib: Get rid of PeCoffLoaderProtocol

2023-03-13 Thread Leif Lindholm
No objection as such, but do we know what it was ever used for? / Leif On Mon, Mar 13, 2023 at 14:45:17 +0100, Ard Biesheuvel wrote: > Signed-off-by: Ard Biesheuvel > --- > EmbeddedPkg/EmbeddedPkg.dec | 1 - > EmbeddedPkg/Include/Library/PrePiLib.h | 6 - > Embedded

[edk2-devel] [PATCH] EmbeddedPkg/PrePiHobLib: Get rid of PeCoffLoaderProtocol

2023-03-13 Thread Ard Biesheuvel
Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/EmbeddedPkg.dec | 1 - EmbeddedPkg/Include/Library/PrePiLib.h | 6 - EmbeddedPkg/Include/Protocol/PeCoffLoader.h | 220 EmbeddedPkg/Library/PrePiHobLib/Hob.c | 22 -- EmbeddedPkg/Library/PrePiLib/Pr